Re: [PATCH] pack-objects: handle island check for "external" delta base

2018-09-19 Thread Jeff King
On Wed, Sep 19, 2018 at 08:34:05PM +0200, Martin Ågren wrote: > > + /* > > +* First see if we're already sending the base (or it's explicitly > > in > > +* our "excluded" list. > > +*/ > > Missing ')'. Oops, yes. > > + if (use_delta_islands) { > > +

Re: [PATCH] pack-objects: handle island check for "external" delta base

2018-09-19 Thread Martin Ågren
On Wed, 19 Sep 2018 at 05:49, Jeff King wrote: > This is tricky to do inside a single "if" statement. And > after the merge in f3504ea3dd (Merge branch > 'cc/delta-islands', 2018-09-17), that "if" condition is > already getting pretty unwieldy. So this patch moves the > logic into a helper

[PATCH] pack-objects: handle island check for "external" delta base

2018-09-18 Thread Jeff King
On Fri, Sep 14, 2018 at 02:56:36PM -0700, Junio C Hamano wrote: > * cc/delta-islands (2018-08-16) 7 commits > (merged to 'next' on 2018-08-27 at cf3d7bd93f) > + pack-objects: move 'layer' into 'struct packing_data' > + pack-objects: move tree_depth into 'struct packing_data' > + t5320: tests