Re: [PATCH] packfile: Correct zlib buffer handling

Hi, Sorry about the delay here (bit of a mix-up and didn't reply to the list). (see inline ) On Sun, May 27, 2018 at 9:41 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Duy Nguyen writes: >> >>> On Sun, May 27, 2018 at 1:57 AM, Junio C Hamano wrote: (trimming) > > Specifically, I

Re: [PATCH] packfile: Correct zlib buffer handling

Junio C Hamano writes: > Duy Nguyen writes: > >> On Sun, May 27, 2018 at 1:57 AM, Junio C Hamano wrote: >>> Duy Nguyen writes: >>> On Sat, May 26, 2018 at 12:56 AM, Jeremy Linton

Re: [PATCH] packfile: Correct zlib buffer handling

Duy Nguyen writes: > On Sun, May 27, 2018 at 1:57 AM, Junio C Hamano wrote: >> Duy Nguyen writes: >> >>> On Sat, May 26, 2018 at 12:56 AM, Jeremy Linton >>> wrote: @@ -1416,7 +1416,7 @@ static void

Re: [PATCH] packfile: Correct zlib buffer handling

On Sun, May 27, 2018 at 1:57 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> On Sat, May 26, 2018 at 12:56 AM, Jeremy Linton >> wrote: >>> @@ -1416,7 +1416,7 @@ static void *unpack_compressed_entry(struct >>> packed_git *p,

Re: [PATCH] packfile: Correct zlib buffer handling

Duy Nguyen writes: > On Sat, May 26, 2018 at 12:56 AM, Jeremy Linton > wrote: >> @@ -1416,7 +1416,7 @@ static void *unpack_compressed_entry(struct packed_git >> *p, >> return NULL; >> memset(, 0, sizeof(stream)); >>

Re: [PATCH] packfile: Correct zlib buffer handling

On Sat, May 26, 2018 at 12:56 AM, Jeremy Linton wrote: > @@ -1416,7 +1416,7 @@ static void *unpack_compressed_entry(struct packed_git > *p, > return NULL; > memset(, 0, sizeof(stream)); > stream.next_out = buffer; > -

Re: [PATCH] packfile: Correct zlib buffer handling

Jeremy Linton wrote: > The buffer being passed to zlib includes a null terminator that > git needs to keep in place. unpack_compressed_entry() attempts to > detect the case that the source buffer hasn't been fully consumed > by checking to see if the destination buffer has been over consumed. > >

Re: [PATCH] packfile: Correct zlib buffer handling

On Fri, May 25, 2018 at 7:17 PM, Jeremy Linton wrote: > The buffer being passed to zlib includes a null terminator that > git needs to keep in place. unpack_compressed_entry() attempts to > detect the case that the source buffer hasn't been fully consumed > by checking to

[PATCH] packfile: Correct zlib buffer handling

The buffer being passed to zlib includes a null terminator that git needs to keep in place. unpack_compressed_entry() attempts to detect the case that the source buffer hasn't been fully consumed by checking to see if the destination buffer has been over consumed. This yields two problems, first

[PATCH] packfile: Correct zlib buffer handling

The buffer being passed to zlib includes a null terminator that git needs to keep in place. unpack_compressed_entry() attempts to detect the case that the source buffer hasn't been fully consumed by checking to see if the destination buffer has been over consumed. This yields two problems, first