Re: [PATCH] packfile: use get_be64() for large offsets

2018-01-17 Thread Jeff King
On Wed, Jan 17, 2018 at 02:08:23PM -0500, Derrick Stolee wrote: > The pack-index version 2 format uses two 4-byte integers in network-byte > order to represent one 8-byte value. The current implementation has several > code clones for stitching these integers together. Yeah, this seems like a

[PATCH] packfile: use get_be64() for large offsets

2018-01-17 Thread Derrick Stolee
The pack-index version 2 format uses two 4-byte integers in network-byte order to represent one 8-byte value. The current implementation has several code clones for stitching these integers together. Use get_be64() to create an 8-byte integer from two 4-byte integers represented this way.