Re: [PATCH] parse-options-cb.c: use string_list_append_nodup in OPT_STRING_LIST()

On Mon, Jun 13, 2016 at 5:03 AM, Jeff King wrote: > On Fri, Jun 10, 2016 at 06:57:26PM +0700, Nguyễn Thái Ngọc Duy wrote: > >> If the given string list has strdup_strings set (*), the string will be >> duplicated again. Pointless and leak memory. Ignore that flag. >> >> (*) only

Re: [PATCH] parse-options-cb.c: use string_list_append_nodup in OPT_STRING_LIST()

On Fri, Jun 10, 2016 at 06:57:26PM +0700, Nguyễn Thái Ngọc Duy wrote: > If the given string list has strdup_strings set (*), the string will be > duplicated again. Pointless and leak memory. Ignore that flag. > > (*) only interpret-trailers.c does it at the moment > > Signed-off-by: Nguyễn Thái

[PATCH] parse-options-cb.c: use string_list_append_nodup in OPT_STRING_LIST()

If the given string list has strdup_strings set (*), the string will be duplicated again. Pointless and leak memory. Ignore that flag. (*) only interpret-trailers.c does it at the moment Signed-off-by: Nguyễn Thái Ngọc Duy --- parse-options-cb.c | 2 +- 1 file changed, 1