Re: [PATCH] protocol: treat unrecognized protocol.version setting as 0

2018-02-28 Thread Jonathan Nieder
Hi, Junio C Hamano wrote: > Jonathan Nieder writes: >> If I share my .gitconfig or .git/config file between multiple machines >> (or between multiple Git versions on a single machine) and set >> >> [protocol] >> version = 2 >> >> then running "git fetch"

Re: [PATCH] protocol: treat unrecognized protocol.version setting as 0

2018-02-28 Thread Junio C Hamano
Junio C Hamano writes: > Jonathan Nieder writes: > >>> I wonder if it's better to specify multiple versions. If v2 is not >>> recognized by this git but v0 is, then it can pick that up. But if you >>> explicitly tell it to choose between v2 and v3 only and

Re: [PATCH] protocol: treat unrecognized protocol.version setting as 0

2018-02-28 Thread Junio C Hamano
Jonathan Nieder writes: >> I wonder if it's better to specify multiple versions. If v2 is not >> recognized by this git but v0 is, then it can pick that up. But if you >> explicitly tell it to choose between v2 and v3 only and it does not >> understand either, then it dies.

Re: [PATCH] protocol: treat unrecognized protocol.version setting as 0

2018-02-28 Thread Junio C Hamano
Jonathan Nieder writes: > If I share my .gitconfig or .git/config file between multiple machines > (or between multiple Git versions on a single machine) and set > > [protocol] > version = 2 > > then running "git fetch" with a Git version that does not

Re: [PATCH] protocol: treat unrecognized protocol.version setting as 0

2018-02-27 Thread Jonathan Nieder
Duy Nguyen wrote: > On Wed, Feb 28, 2018 at 8:02 AM, Brandon Williams wrote: >> On 02/27, Jonathan Nieder wrote: >>> If I share my .gitconfig or .git/config file between multiple machines >>> (or between multiple Git versions on a single machine) and set >>> >>>

Re: [PATCH] protocol: treat unrecognized protocol.version setting as 0

2018-02-27 Thread Brandon Williams
On 02/28, Duy Nguyen wrote: > On Wed, Feb 28, 2018 at 8:02 AM, Brandon Williams wrote: > > On 02/27, Jonathan Nieder wrote: > >> If I share my .gitconfig or .git/config file between multiple machines > >> (or between multiple Git versions on a single machine) and set > >> > >>

Re: [PATCH] protocol: treat unrecognized protocol.version setting as 0

2018-02-27 Thread Duy Nguyen
On Wed, Feb 28, 2018 at 8:02 AM, Brandon Williams wrote: > On 02/27, Jonathan Nieder wrote: >> If I share my .gitconfig or .git/config file between multiple machines >> (or between multiple Git versions on a single machine) and set >> >> [protocol] >>

Re: [PATCH] protocol: treat unrecognized protocol.version setting as 0

2018-02-27 Thread Brandon Williams
On 02/27, Jonathan Nieder wrote: > If I share my .gitconfig or .git/config file between multiple machines > (or between multiple Git versions on a single machine) and set > > [protocol] > version = 2 > > then running "git fetch" with a Git version that does not support >

[PATCH] protocol: treat unrecognized protocol.version setting as 0

2018-02-27 Thread Jonathan Nieder
If I share my .gitconfig or .git/config file between multiple machines (or between multiple Git versions on a single machine) and set [protocol] version = 2 then running "git fetch" with a Git version that does not support protocol v2 errors out with fatal: