Re: [PATCH] pull: pass --signoff/--no-signoff to "git merge"

Junio C Hamano writes: > get_signoff () { > git cat-file commit "$1" | sed -n -e '/^Signed-off-by: /p' > } > > Some may say "cat-file can fail, and having it on the LHS of a pipe > hides its failure", advocating for something like: > >

Re: [PATCH] pull: pass --signoff/--no-signoff to "git merge"

On Thu, Oct 12, 2017 at 02:42:30PM +0900, Junio C Hamano wrote: > "W. Trevor King" writes: > > On Thu, Oct 12, 2017 at 10:17:51AM +0900, Junio C Hamano wrote: > >> "W. Trevor King" writes: > >> > >> > Following 09c2cb87 (pull: pass --allow-unrelated-histories

Re: [PATCH] pull: pass --signoff/--no-signoff to "git merge"

"W. Trevor King" writes: > On Thu, Oct 12, 2017 at 10:17:51AM +0900, Junio C Hamano wrote: >> "W. Trevor King" writes: >> >> > Following 09c2cb87 (pull: pass --allow-unrelated-histories to "git >> > merge", 2016-03-18) with the tests also drawing on 14d01b4f

Re: [PATCH] pull: pass --signoff/--no-signoff to "git merge"

On Thu, Oct 12, 2017 at 10:17:51AM +0900, Junio C Hamano wrote: > "W. Trevor King" writes: > > > Following 09c2cb87 (pull: pass --allow-unrelated-histories to "git > > merge", 2016-03-18) with the tests also drawing on 14d01b4f (merge: > > add a --signoff flag, 2017-07-04). >

Re: [PATCH] pull: pass --signoff/--no-signoff to "git merge"

"W. Trevor King" writes: > Following 09c2cb87 (pull: pass --allow-unrelated-histories to "git > merge", 2016-03-18) with the tests also drawing on 14d01b4f (merge: > add a --signoff flag, 2017-07-04). I cannot find a verb in the above. > The order of options in

[PATCH] pull: pass --signoff/--no-signoff to "git merge"

Following 09c2cb87 (pull: pass --allow-unrelated-histories to "git merge", 2016-03-18) with the tests also drawing on 14d01b4f (merge: add a --signoff flag, 2017-07-04). The order of options in merge-options.txt isn't clear to me, but I've put --signoff between --log and --stat as somewhat