Josh Triplett j...@joshtriplett.org writes:
On Wed, Mar 27, 2013 at 05:48:45PM -0500, Rob Hoelz wrote:
...
The test that checked that pushInsteadOf + pushurl shouldn't work as I
expect was actually broken; I have removed it, updated the
documentation, and sent a new patch to the list.
On Thu, Mar 28, 2013 at 08:37:58AM -0700, Junio C Hamano wrote:
Josh Triplett j...@joshtriplett.org writes:
On Wed, Mar 27, 2013 at 05:48:45PM -0500, Rob Hoelz wrote:
...
The test that checked that pushInsteadOf + pushurl shouldn't work as I
expect was actually broken; I have removed
Josh Triplett j...@joshtriplett.org writes:
OK, I take it back. I *can* imagine configurations that this change
would break, since it does change intentional and documented behavior,
but I don't have any such configuration. The only such configuration I
can imagine involves directly
On Thu, Mar 28, 2013 at 09:10:59AM -0700, Junio C Hamano wrote:
Josh Triplett j...@joshtriplett.org writes:
OK, I take it back. I *can* imagine configurations that this change
would break, since it does change intentional and documented behavior,
but I don't have any such configuration.
Josh Triplett j...@joshtriplett.org writes:
(on url.$base.pushInsteadOf)
If a remote has an explicit pushurl, git will ignore this setting for
that remote.
That really meant what I just said above: git will prefer an explicit
pushurl over the pushInsteadOf rewrite of url.
Very correct.
It
On Thu, Mar 28, 2013 at 11:50:08AM -0700, Junio C Hamano wrote:
Josh Triplett j...@joshtriplett.org writes:
(on url.$base.pushInsteadOf)
If a remote has an explicit pushurl, git will ignore this setting for
that remote.
That really meant what I just said above: git will prefer an explicit
Josh Triplett wrote:
Related to this, as a path forward, I do think it makes sense to have a
setting usable as an insteadOf that only applies to pushurl, even though
pushInsteadOf won't end up serving that purpose. That way,
pushInsteadOf covers the map read-only repo url to pushable repo
On Thu, 28 Mar 2013 12:25:07 -0700
Jonathan Nieder jrnie...@gmail.com wrote:
Josh Triplett wrote:
Related to this, as a path forward, I do think it makes sense to
have a setting usable as an insteadOf that only applies to pushurl,
even though pushInsteadOf won't end up serving that
Rob Hoelz r...@hoelz.ro writes:
Honestly, if my workflow here is stupid and not Git-like and someone
has a better suggestion, I would happy to let my patch go. Using two
remotes is an option, but to me, using this triangular setup is just
easier.
I think you are conflating two unrelated
On Wed, 20 Mar 2013 07:35:58 -0700
Junio C Hamano gits...@pobox.com wrote:
Rob Hoelz r...@hoelz.ro writes:
On 3/19/13 7:08 PM, Junio C Hamano wrote:
Jonathan Nieder jrnie...@gmail.com writes:
Junio C Hamano wrote:
Jonathan Nieder jrnie...@gmail.com writes:
Test nits:
...
Hope
git push currently doesn't consider pushInsteadOf when
using pushurl; this test tests that.
If you use pushurl with an alias that has a pushInsteadOf configuration
value, Git does not take advantage of it. For example:
[url git://github.com/]
insteadOf = github:
[url
Rob Hoelz wrote:
--- a/remote.c
+++ b/remote.c
@@ -465,7 +465,11 @@ static void alias_all_urls(void)
if (!remotes[i])
continue;
for (j = 0; j remotes[i]-pushurl_nr; j++) {
- remotes[i]-pushurl[j] =
Jonathan Nieder jrnie...@gmail.com writes:
Sorry, typo. The configuration in the example above should have been
[url git://anongit.myserver.example.com/]
insteadOf = myserver.example.com:
[url myserver.example.com:]
pushInsteadOf =
On Wed, 27 Mar 2013 15:07:18 -0700
Junio C Hamano gits...@pobox.com wrote:
Jonathan Nieder jrnie...@gmail.com writes:
Sorry, typo. The configuration in the example above should have
been
[url git://anongit.myserver.example.com/]
insteadOf = myserver.example.com:
On Wed, 27 Mar 2013 15:47:35 -0700
Jonathan Nieder jrnie...@gmail.com wrote:
Hi,
Rob Hoelz wrote:
On Wed, 27 Mar 2013 11:23:45 -0700
Jonathan Nieder jrnie...@gmail.com wrote:
Suppose I configure
[url git://anongit.myserver.example.com/]
insteadOf =
Rob Hoelz wrote:
My mistake; I had not seen it! I thought you may have found a bug in
my implementation, so I wanted to double check. =)
Well, I had found an unfortunate consequence of the implementation
that uses an unnecessary copy. :)
Will follow up to the updated patch.
--
To unsubscribe
On Wed, 27 Mar 2013 15:56:56 -0700
Jonathan Nieder jrnie...@gmail.com wrote:
Rob Hoelz wrote:
My mistake; I had not seen it! I thought you may have found a bug
in my implementation, so I wanted to double check. =)
Well, I had found an unfortunate consequence of the implementation
that
On Wed, Mar 27, 2013 at 05:48:45PM -0500, Rob Hoelz wrote:
On Wed, 27 Mar 2013 15:07:18 -0700
Junio C Hamano gits...@pobox.com wrote:
Jonathan Nieder jrnie...@gmail.com writes:
Sorry, typo. The configuration in the example above should have
been
[url
On Wed, Mar 27, 2013 at 04:09:43PM -0700, Josh Triplett wrote:
On Wed, Mar 27, 2013 at 05:48:45PM -0500, Rob Hoelz wrote:
On Wed, 27 Mar 2013 15:07:18 -0700
Junio C Hamano gits...@pobox.com wrote:
Jonathan Nieder jrnie...@gmail.com writes:
Sorry, typo. The configuration in the
Josh Triplett wrote:
I have a .gitconfig in my git-managed home
directory which sets pushInsteadOf so that I can clone via git:// and
immediately have working push. I work with a number of systems that
don't have inbound access to each other but do have outbound access
On 3/19/13 7:08 PM, Junio C Hamano wrote:
Jonathan Nieder jrnie...@gmail.com writes:
Junio C Hamano wrote:
Jonathan Nieder jrnie...@gmail.com writes:
Test nits:
...
Hope that helps,
Jonathan Nieder (3):
push test: use test_config where appropriate
push test: simplify check of push
Jonathan Nieder jrnie...@gmail.com writes:
Junio C Hamano wrote:
Jonathan Nieder jrnie...@gmail.com writes:
Test nits:
...
Hope that helps,
Jonathan Nieder (3):
push test: use test_config where appropriate
push test: simplify check of push result
push test: rely on -chaining
On 3/18/13 12:35 AM, Junio C Hamano wrote:
Rob Hoelz r...@hoelz.ro writes:
git push currently doesn't consider pushInsteadOf when
using pushurl; this tests and fixes that.
If you use pushurl with an alias that has a pushInsteadOf configuration
value, Git does not take advantage of it. For
On Sun, 17 Mar 2013 16:35:59 -0700
Junio C Hamano gits...@pobox.com wrote:
Rob Hoelz r...@hoelz.ro writes:
git push currently doesn't consider pushInsteadOf when
using pushurl; this tests and fixes that.
If you use pushurl with an alias that has a pushInsteadOf
configuration value,
git push currently doesn't consider pushInsteadOf when
using pushurl; this test tests that.
If you use pushurl with an alias that has a pushInsteadOf configuration
value, Git does not take advantage of it. For example:
[url git://github.com/]
insteadOf = github:
[url
Jonathan Nieder jrnie...@gmail.com writes:
Test nits:
...
Hope that helps,
Jonathan Nieder (3):
push test: use test_config where appropriate
push test: simplify check of push result
push test: rely on -chaining instead of 'if bad; then echo Oops; fi'
Are these supposed to be
Junio C Hamano wrote:
Jonathan Nieder jrnie...@gmail.com writes:
Test nits:
...
Hope that helps,
Jonathan Nieder (3):
push test: use test_config where appropriate
push test: simplify check of push result
push test: rely on -chaining instead of 'if bad; then echo Oops; fi'
Are
git push currently doesn't consider pushInsteadOf when
using pushurl; this tests and fixes that.
If you use pushurl with an alias that has a pushInsteadOf configuration
value, Git does not take advantage of it. For example:
[url git://github.com/]
insteadOf = github:
[url
Rob Hoelz r...@hoelz.ro writes:
git push currently doesn't consider pushInsteadOf when
using pushurl; this tests and fixes that.
If you use pushurl with an alias that has a pushInsteadOf configuration
value, Git does not take advantage of it. For example:
[url git://github.com/]
29 matches
Mail list logo
