Re: [PATCH] push: change needlessly ambiguous example in error

2018-11-14 Thread Junio C Hamano
Matthieu Moy writes: > "Junio C Hamano" wrote: > >> > Where 'topic' is a tracking branch of 'origin/master' (I use >> > push.default=upstream). I only recently discovered that I could push to >> > 'HEAD" to do the same thing. So one ulterior motive is to make that more >> > prominent. > [...]

Re: [PATCH] push: change needlessly ambiguous example in error

2018-11-13 Thread Matthieu Moy
"Junio C Hamano" wrote: > > Where 'topic' is a tracking branch of 'origin/master' (I use > > push.default=upstream). I only recently discovered that I could push to > > 'HEAD" to do the same thing. So one ulterior motive is to make that more > > prominent. [...] > Do we consider the current

Re: [PATCH] push: change needlessly ambiguous example in error

2018-11-13 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: >> This "git push origin HEAD" is IMHO less common. It may confuse users. >> Or users may learn it and be happy thanks to your message. I don't know. > > I was hoping for the latter. I'm slightly embarrassed to say that for > the entire time I've been using git

Re: [PATCH] push: change needlessly ambiguous example in error

2018-11-13 Thread Matthieu Moy
Ævar Arnfjörð Bjarmason" wrote: > Let's use "git push HEAD" which always means push the current > branch name to that remote, instead of "git push > " which will do that under "simple", but is not > guaranteed to do under "upstream". Probably a good idea indeed. One potential objection

Re: [PATCH] push: change needlessly ambiguous example in error

2018-11-13 Thread Ævar Arnfjörð Bjarmason
On Tue, Nov 13 2018, Matthieu Moy wrote: > Ævar Arnfjörð Bjarmason" wrote: > >> Let's use "git push HEAD" which always means push the current >> branch name to that remote, instead of "git push >> " which will do that under "simple", but is not >> guaranteed to do under "upstream". > >

[PATCH] push: change needlessly ambiguous example in error

2018-11-13 Thread Ævar Arnfjörð Bjarmason
Change an example push added in b55e677522 ("push: introduce new push.default mode "simple"", 2012-04-24) to always mean the same thing whether the current setting happens to be "simple" or not. This error is only emitted under "simple", but message is explaining to the user that they can get two