Re: [PATCH] push: do not use potentially ambiguous default refspec

2016-10-31 Thread Junio C Hamano
Dennis Kaarsemaker writes: > On Fri, Oct 28, 2016 at 12:25:30PM -0700, Junio C Hamano wrote: > >> * It is appreciated if somebody with spare cycles can add a test or >>two for this in t/t5523-push-upstream.sh or somewhere nearby. > > 5523 is for push --set-upstream-to, 5528 seemed more appro

Re: [PATCH] push: do not use potentially ambiguous default refspec

2016-10-31 Thread Dennis Kaarsemaker
On Fri, Oct 28, 2016 at 12:25:30PM -0700, Junio C Hamano wrote: > * It is appreciated if somebody with spare cycles can add a test or >two for this in t/t5523-push-upstream.sh or somewhere nearby. 5523 is for push --set-upstream-to, 5528 seemed more appropriate. Here's something squashable t

[PATCH] push: do not use potentially ambiguous default refspec

2016-10-28 Thread Junio C Hamano
When the user does the lazy "git push" with no parameters with push.default set to either "upstream", "simple" or "current", we internally generated a refspec that has the current branch name on the source side and used it to push. However, the branch name (say "test") may be an ambiguous refname