Re: [PATCH] read-cache: fix index corruption with index v4

2017-09-06 Thread Thomas Gummerer
On Tue, Sep 5, 2017 at 8:37 PM, Kevin Willford wrote: >> From: Thomas Gummerer [mailto:t.gumme...@gmail.com] >> Sent: Monday, September 4, 2017 4:58 PM [..] >> I unfortunately didn't have more time to dig so >> >> > As ce->name is however not nul terminated >> >> just

RE: [PATCH] read-cache: fix index corruption with index v4

2017-09-05 Thread Kevin Willford
> From: Thomas Gummerer [mailto:t.gumme...@gmail.com] > Sent: Monday, September 4, 2017 4:58 PM > > ce012deb98 ("read-cache: avoid allocating every ondisk entry when > writing", 2017-08-21) changed the way cache entries are written to the > index file. While previously it wrote the name to an

[PATCH] read-cache: fix index corruption with index v4

2017-09-04 Thread Thomas Gummerer
ce012deb98 ("read-cache: avoid allocating every ondisk entry when writing", 2017-08-21) changed the way cache entries are written to the index file. While previously it wrote the name to an struct that was allocated using xcalloc(), it now uses ce_write() directly. Previously ce_namelen - common