[PATCH] rebase -x: do not die without -i

2016-03-19 Thread Stefan Beller
In the later steps of preparing a patch series I do not want to edit the patches any more, but just make sure the test suite passes after each patch. Currently I would run EDITOR=true git rebase -i -x "make test" In an ideal world the command would be simpler and just be git rebase -x "mak

Re: [PATCH] rebase -x: do not die without -i

2016-03-18 Thread Junio C Hamano
Stefan Beller writes: > In the later steps of preparing a patch series I do not want to edit the > patches any more, but just make sure the test suite passes after each > patch. Currently I would run > > EDITOR=true git rebase -i -x "make test" Hmm, I guess that may "work" but it sounds like

Re: [PATCH] rebase -x: do not die without -i

2016-03-19 Thread Johannes Sixt
Am 17.03.2016 um 02:19 schrieb Stefan Beller: -test_expect_success 'rebase --exec without -i shows error message' ' +test_expect_success 'rebase --exec works without -i ' ' git reset --hard execute && - set_fake_editor && - test_must_fail git rebase --exec "git show HEAD" HEAD

Re: [PATCH] rebase -x: do not die without -i

2016-03-19 Thread Johannes Schindelin
Hi Stefan, On Wed, 16 Mar 2016, Stefan Beller wrote: > In the later steps of preparing a patch series I do not want to edit the > patches any more, but just make sure the test suite passes after each > patch. Currently I would run > > EDITOR=true git rebase -i -x "make test" > > In an ideal

Re: [PATCH] rebase -x: do not die without -i

2016-03-19 Thread Johannes Schindelin
Hi Junio, On Thu, 17 Mar 2016, Junio C Hamano wrote: > I guess that may "work" but it sounds like quite a roundabout > way to "test all commits". "rebase" is about replaying history to > end up with a set of newly minted commits, and being able to poke at > the state each commit records in the w

Re: [PATCH] rebase -x: do not die without -i

2016-03-19 Thread Junio C Hamano
Johannes Schindelin writes: > And that is very, very much the purpose of the interactive rebase. > >> $ git for-each-rev -x "$command" old..new >> >> where you can write "sh -c 'git checkout $1 && make test' -" as >> your $command. > > You meant > > git rev-list old...new | > whi