On Sat, Mar 18, 2017 at 10:12:07AM -0700, Junio C Hamano wrote:
> >> - argv_array_push(&proc.args, hook);
> >>for (cmd = commands; cmd; cmd = cmd->next) {
> >>if (cmd->error_string || cmd->did_not_exist)
> >>continue;
> >> + if (!proc.args.argc)
> >> +
Jeff King writes:
> On Fri, Mar 17, 2017 at 11:02:13PM +0100, René Scharfe wrote:
>
>> Instead of counting the arguments to see if there are any and then
>> building the full command use a single loop and add the hook command
>> just before the first argument. This reduces duplication and overal
René Scharfe wrote:
> Instead of counting the arguments to see if there are any and then
> building the full command use a single loop and add the hook command
> just before the first argument. This reduces duplication and overall
> code size.
>
> Signed-off-by: Rene Scharfe
> ---
> builtin/rec
Am 17.03.2017 um 23:23 schrieb Jeff King:
On Fri, Mar 17, 2017 at 11:02:13PM +0100, René Scharfe wrote:
Instead of counting the arguments to see if there are any and then
building the full command use a single loop and add the hook command
just before the first argument. This reduces duplicati
On Fri, Mar 17, 2017 at 11:02:13PM +0100, René Scharfe wrote:
> Instead of counting the arguments to see if there are any and then
> building the full command use a single loop and add the hook command
> just before the first argument. This reduces duplication and overall
> code size.
Yeah, I ag
Instead of counting the arguments to see if there are any and then
building the full command use a single loop and add the hook command
just before the first argument. This reduces duplication and overall
code size.
Signed-off-by: Rene Scharfe
---
builtin/receive-pack.c | 13 +
1 fi
6 matches
Mail list logo