Re: [PATCH] ref-filter: fallback on alphabetical comparison

2015-10-25 Thread Karthik Nayak
On Sun, Oct 25, 2015 at 5:48 AM, Eric Sunshine wrote: > On Sat, Oct 24, 2015 at 10:42 AM, Karthik Nayak wrote: >> In ref-filter.c the comparison of refs while sorting is handled by >> cmp_ref_sorting() function. When sorting as per numerical values

[PATCH] ref-filter: fallback on alphabetical comparison

2015-10-24 Thread Karthik Nayak
In ref-filter.c the comparison of refs while sorting is handled by cmp_ref_sorting() function. When sorting as per numerical values (e.g. --sort=objectsize) there is no fallback comparison when both refs hold the same value. This can cause unexpected results as pointed out by Johannes Sixt

Re: [PATCH] ref-filter: fallback on alphabetical comparison

2015-10-24 Thread Eric Sunshine
On Sat, Oct 24, 2015 at 10:42 AM, Karthik Nayak wrote: > In ref-filter.c the comparison of refs while sorting is handled by > cmp_ref_sorting() function. When sorting as per numerical values > (e.g. --sort=objectsize) there is no fallback comparison when both refs > hold