[PATCH] reflog expire: add progress output

2018-09-19 Thread Ævar Arnfjörð Bjarmason
Before this change the "git reflog expire" command didn't report any progress. This is the second command (after "pack-refs --all --prune") that the "gc" command will run. On small repositories like this command won't take long to run, my test system it takes just under 1 second to run on git.git,

Re: [PATCH] reflog expire: add progress output

2018-09-19 Thread Duy Nguyen
On Wed, Sep 19, 2018 at 4:23 PM Ævar Arnfjörð Bjarmason wrote: > Before this change the "git reflog expire" command didn't report any > progress. I love these progress additions you've been pushing lately :) > diff --git a/builtin/reflog.c b/builtin/reflog.c > index 3acef5a0ab..d3075ee75a 100644

Re: [PATCH] reflog expire: add progress output

2018-09-19 Thread Ævar Arnfjörð Bjarmason
On Wed, Sep 19 2018, Duy Nguyen wrote: > On Wed, Sep 19, 2018 at 4:23 PM Ævar Arnfjörð Bjarmason > wrote: >> Before this change the "git reflog expire" command didn't report any >> progress. > > I love these progress additions you've been pushing lately :) > >> diff --git a/builtin/reflog.c b/b

Re: [PATCH] reflog expire: add progress output

2018-09-19 Thread Jeff King
On Wed, Sep 19, 2018 at 07:22:44PM +0200, Ævar Arnfjörð Bjarmason wrote: > > Do we have --quiet option or something that needs to completely > > suppress this progress thing? > > Yes. I also see my commit graph process patches sitting in "next" broke > the "git gc --quiet" mode, and I'll need to

Re: [PATCH] reflog expire: add progress output

2018-09-19 Thread Ævar Arnfjörð Bjarmason
On Wed, Sep 19 2018, Jeff King wrote: > On Wed, Sep 19, 2018 at 07:22:44PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> > Do we have --quiet option or something that needs to completely >> > suppress this progress thing? >> >> Yes. I also see my commit graph process patches sitting in "next" broke

Re: [PATCH] reflog expire: add progress output

2018-09-20 Thread Duy Nguyen
On Wed, Sep 19, 2018 at 07:22:44PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> @@ -225,14 +226,20 @@ static void mark_reachable(struct > >> expire_reflog_policy_cb *cb) > >> struct commit_list *pending; > >> timestamp_t expire_limit = cb->mark_limit; > >> struct commit_list

Re: [PATCH] reflog expire: add progress output

2018-09-20 Thread Eric Sunshine
On Wed, Sep 19, 2018 at 10:10 AM Ævar Arnfjörð Bjarmason wrote: > Before this change the "git reflog expire" command didn't report any > progress. This is the second command (after "pack-refs --all --prune") > that the "gc" command will run. > [...] > That may just be some artifact of the reposito