subject:"\[PATCH\] refs.c\: fix fread error handling"

Re: [PATCH] refs.c: fix fread error handling

2013-03-23 Thread Junio C Hamano

Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] refs.c: fix fread error handling

2013-03-23 Thread John Keeping

fread returns the number of items read, with no special error return. Commit 98f85ff (reflog: add for_each_reflog_ent_reverse() API - 2013-03-08) introduced a call to fread which checks for an error with "nread < 0" which is tautological since nread is unsigned. The correct check in this case (wh