[PATCH] refs.c: use a stringlist for repack_without_refs

2014-11-19 Thread Stefan Beller
From: Ronnie Sahlberg This patch doesn't intend any functional changes. It is just a refactoring, which replaces a char** array by a stringlist in the function repack_without_refs. This is easier to read and maintain as it delivers the same functionality with less lines of code and less pointers.

Re: [PATCH] refs.c: use a stringlist for repack_without_refs

2014-11-19 Thread Jonathan Nieder
Stefan Beller wrote: > This patch doesn't intend any functional changes. Yay. :) > a refactoring, which replaces a char** array by a stringlist > in the function repack_without_refs. > This is easier to read and maintain as it delivers the same > functionality with less lines of code and less po

[PATCH] refs.c: use a stringlist for repack_without_refs

2014-11-19 Thread Stefan Beller
From: Ronnie Sahlberg This patch doesn't intend any functional changes. It is just a refactoring, which replaces a char** array by a stringlist in the function repack_without_refs. This is easier to read and maintain as it delivers the same functionality with less lines of code and less pointers.

Re: [PATCH] refs.c: use a stringlist for repack_without_refs

2014-11-19 Thread Junio C Hamano
Stefan Beller writes: > This patch doesn't intend any functional changes. It is just > a refactoring, which replaces a char** array by a stringlist > in the function repack_without_refs. > This is easier to read and maintain as it delivers the same > functionality with less lines of code less poi

[PATCH] refs.c: use a stringlist for repack_without_refs

2014-11-18 Thread Stefan Beller
This patch doesn't intend any functional changes. It is just a refactoring, which replaces a char** array by a stringlist in the function repack_without_refs. This is easier to read and maintain as it delivers the same functionality with less lines of code less pointers. Signed-off-by: Ronnie Sahl

Re: [PATCH] refs.c: use a stringlist for repack_without_refs

2014-11-18 Thread Stefan Beller
On Tue, Nov 18, 2014 at 3:45 PM, Jonathan Nieder wrote: > > The above is a useful kind of comment to put below the three-dashes. It > doesn't explain what the intent behind the patch is, why I should want > this patch when considering whether to upgrade git, or what is going to > break when I con

Re: [PATCH] refs.c: use a stringlist for repack_without_refs

2014-11-18 Thread Jonathan Nieder
Stefan Beller wrote: > This patch was heavily inspired by a part of the ref-transactions-rename > series[1], but people tend to dislike large series and this part is > relatively easy to take out and unrelated, so I'll send it as a single > patch. > > [1] https://www.mail-archive.com/git@vger.kern

Re: [PATCH] refs.c: use a stringlist for repack_without_refs

2014-11-18 Thread Junio C Hamano
Junio C Hamano writes: > Stefan Beller writes: > >> This patch was heavily inspired by a part of the ref-transactions-rename >> series[1], but people tend to dislike large series and this part is >> relatively easy to take out and unrelated, so I'll send it as a single >> patch. >> >> This patch

Re: [PATCH] refs.c: use a stringlist for repack_without_refs

2014-11-18 Thread Junio C Hamano
Stefan Beller writes: > This patch was heavily inspired by a part of the ref-transactions-rename > series[1], but people tend to dislike large series and this part is > relatively easy to take out and unrelated, so I'll send it as a single > patch. > > This patch doesn't intend any functional cha

[PATCH] refs.c: use a stringlist for repack_without_refs

2014-11-18 Thread Stefan Beller
This patch was heavily inspired by a part of the ref-transactions-rename series[1], but people tend to dislike large series and this part is relatively easy to take out and unrelated, so I'll send it as a single patch. This patch doesn't intend any functional changes. It is just a refactoring, wh