Re: [PATCH] remote: clear string_list after use in mv()

2018-08-02 Thread René Scharfe
Thank you for the review! Am 02.08.2018 um 04:56 schrieb Jonathan Nieder: > René Scharfe wrote: > >> Subject: remote: clear string_list after use in mv() > > This subject line doesn't fully reflect the goodness of this change. > How about something like: > > remote mv: avoid leaking ref

Re: [PATCH] remote: clear string_list after use in mv()

2018-08-01 Thread Jonathan Nieder
Hi, René Scharfe wrote: > Subject: remote: clear string_list after use in mv() This subject line doesn't fully reflect the goodness of this change. How about something like: remote mv: avoid leaking ref names in string_list ? > Switch to the _DUP variant of string_list for

[PATCH] remote: clear string_list after use in mv()

2018-08-01 Thread René Scharfe
Switch to the _DUP variant of string_list for remote_branches to allow string_list_clear() to release the allocated memory at the end, and actually call that function. Free the util pointer as well; it is allocated in read_remote_branches(). NB: This string_list is empty until