Re: [PATCH] remote.c - Make remote definition require a url

2014-10-13 Thread Mark Levedahl
On 10/13/2014 01:19 PM, Junio C Hamano wrote: Mark Levedahl writes: Some options may be configured globally for a remote (e.g, tagopt). Or some remotes may have only pushurl and not url. "git remote" output for me has a few such remotes but wouldn't this patch break it? If a caller that wal

Re: [PATCH] remote.c - Make remote definition require a url

2014-10-13 Thread Junio C Hamano
Mark Levedahl writes: > Some options may be configured globally for a remote (e.g, tagopt). Or some remotes may have only pushurl and not url. "git remote" output for me has a few such remotes but wouldn't this patch break it? If a caller that walks the list of remotes misbehaves only because

[PATCH] remote.c - Make remote definition require a url

2014-10-11 Thread Mark Levedahl
Some options may be configured globally for a remote (e.g, tagopt). The presence of such options in a global config should not cause git remote or get fetch to believe that remote is configured for every repository. Change to require definition of remote..url for the remote to be included in "git f