[PATCH] replace: parse revision argument for -d

2012-10-26 Thread Michael J Gruber
'git replace' parses the revision arguments when it creates replacements (so that a sha1 can be abbreviated, e.g.) but not when deleting replacements. This sucks. Make it parse the argument to 'replace -d' in the same way. Just in case someone lost the replacement object before deleting the repl

Re: [PATCH] replace: parse revision argument for -d

2012-10-26 Thread Christian Couder
Hi, On Fri, Oct 26, 2012 at 3:33 PM, Michael J Gruber wrote: > 'git replace' parses the revision arguments when it creates replacements > (so that a sha1 can be abbreviated, e.g.) but not when deleting > replacements. > > This sucks. > > Make it parse the argument to 'replace -d' in the same way.

Re: [PATCH] replace: parse revision argument for -d

2012-10-28 Thread Jeff King
On Fri, Oct 26, 2012 at 03:33:27PM +0200, Michael J Gruber wrote: > for (p = argv; *p; p++) { > - if (snprintf(ref, sizeof(ref), "refs/replace/%s", *p) > + q = *p; > + if (get_sha1(q, sha1)) > + warning("Failed to resolve '%s' as a vali

Re: [PATCH] replace: parse revision argument for -d

2012-10-29 Thread Michael J Gruber
Jeff King venit, vidit, dixit 29.10.2012 07:58: > On Fri, Oct 26, 2012 at 03:33:27PM +0200, Michael J Gruber wrote: > >> for (p = argv; *p; p++) { >> -if (snprintf(ref, sizeof(ref), "refs/replace/%s", *p) >> +q = *p; >> +if (get_sha1(q, sha1)) >> +

Re: [PATCH] replace: parse revision argument for -d

2012-10-29 Thread Jeff King
On Mon, Oct 29, 2012 at 10:02:47AM +0100, Michael J Gruber wrote: > Jeff King venit, vidit, dixit 29.10.2012 07:58: > > On Fri, Oct 26, 2012 at 03:33:27PM +0200, Michael J Gruber wrote: > > > >>for (p = argv; *p; p++) { > >> - if (snprintf(ref, sizeof(ref), "refs/replace/%s", *p) > >

Re: [PATCH] replace: parse revision argument for -d

2012-10-29 Thread Michael J Gruber
Jeff King venit, vidit, dixit 29.10.2012 10:04: > On Mon, Oct 29, 2012 at 10:02:47AM +0100, Michael J Gruber wrote: > >> Jeff King venit, vidit, dixit 29.10.2012 07:58: >>> On Fri, Oct 26, 2012 at 03:33:27PM +0200, Michael J Gruber wrote: >>> for (p = argv; *p; p++) { - if (s