Re: [PATCH] repository: pre-initialize hash algo pointer

2018-01-20 Thread Eric Sunshine
On Sat, Jan 20, 2018 at 2:01 AM, Junio C Hamano wrote: > Junio C Hamano writes: >> Eric Sunshine writes: >>> Now that we know (due to Duy's excellent detective work[1]) that the >>> trigger is files with names differing only in case on case-insensitive >>> filesystems, the commit message can be

Re: [PATCH] repository: pre-initialize hash algo pointer

2018-01-19 Thread Junio C Hamano
Junio C Hamano writes: > Eric Sunshine writes: > >>> I'm still quite mystified as to why this is working on Linux and not >>> macOS, but I can only guess that compilers are just very advanced and >>> have somehow concluded that we would clearly never dereference a NULL >>> pointer, so they picke

Re: [PATCH] repository: pre-initialize hash algo pointer

2018-01-19 Thread brian m. carlson
On Fri, Jan 19, 2018 at 11:24:24AM -0800, Junio C Hamano wrote: > Eric Sunshine writes: > > Now that we know (due to Duy's excellent detective work[1]) that the > > trigger is files with names differing only in case on case-insensitive > > filesystems, the commit message can be updated appropriate

Re: [PATCH] repository: pre-initialize hash algo pointer

2018-01-19 Thread Junio C Hamano
t; filesystems, the commit message can be updated appropriately. >> >> Thanks. Let me apply the following and do a 2.16.1, hopefully by >> the end of day or mid tomorrow at the latest. Test to protect the >> fix can come as a separate follow-up patch. >> >&

Re: [PATCH] repository: pre-initialize hash algo pointer

2018-01-19 Thread Eric Sunshine
n be updated appropriately. > > Thanks. Let me apply the following and do a 2.16.1, hopefully by > the end of day or mid tomorrow at the latest. Test to protect the > fix can come as a separate follow-up patch. > > -- >8 -- > Subject: [PATCH] repository: pre-initialize hash algo

Re: [PATCH] repository: pre-initialize hash algo pointer

2018-01-19 Thread Junio C Hamano
o a 2.16.1, hopefully by the end of day or mid tomorrow at the latest. Test to protect the fix can come as a separate follow-up patch. -- >8 -- Subject: [PATCH] repository: pre-initialize hash algo pointer There are various git subcommands (among them, clone) which don't set up the repository

Re: [PATCH] repository: pre-initialize hash algo pointer

2018-01-18 Thread Eric Sunshine
On Thu, Jan 18, 2018 at 11:18 PM, brian m. carlson wrote: > There are various git subcommands (among them, clone) which don't set up > the repository (that is, they lack RUN_SETUP or RUN_SETUP_GENTLY) but > end up needing to have information about the hash algorithm in use. > Because the hash algo

[PATCH] repository: pre-initialize hash algo pointer

2018-01-18 Thread brian m. carlson
There are various git subcommands (among them, clone) which don't set up the repository (that is, they lack RUN_SETUP or RUN_SETUP_GENTLY) but end up needing to have information about the hash algorithm in use. Because the hash algorithm is part of struct repository and it's only initialized in rep