[PATCH] run-command: encode signal death as a positive integer

2013-01-05 Thread Jeff King
-- Subject: [PATCH] run-command: encode signal death as a positive integer When a sub-command dies due to a signal, we encode the signal number into the numeric exit status as signal - 128. This is easy to identify (versus a regular positive error code), and when cast to an unsigned integer (e.g

Re: [PATCH] run-command: encode signal death as a positive integer

2013-01-05 Thread Johannes Sixt
previous email; hopefully it makes sense. -- 8 -- Subject: [PATCH] run-command: encode signal death as a positive integer When a sub-command dies due to a signal, we encode the signal number into the numeric exit status as signal - 128. This is easy to identify (versus a regular positive

Re: [PATCH] run-command: encode signal death as a positive integer

2013-01-05 Thread Jeff King
On Sat, Jan 05, 2013 at 02:19:09PM -0800, Jonathan Nieder wrote: Documentation/technical/api-run-command.txt | 6 ++ editor.c| 2 +- run-command.c | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-)

Re: [PATCH] run-command: encode signal death as a positive integer

2013-01-05 Thread Jonathan Nieder
Jeff King wrote: I'd expecting cooking this patch for a while would flush out any I missed. Heh, probably not. ;-) But I tried to examine all the callsites (and only found the two messages I mentioned), and among the reviewers, I'm guessing we hit them all. Ciao,

Re: [PATCH] run-command: encode signal death as a positive integer

2013-01-05 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Sat, Jan 05, 2013 at 09:03:16AM -0500, Jeff King wrote: ... The downside is that callers of run_command can no longer differentiate between a signal received directly by the sub-process, and one propagated. However, no caller currently cares, and since we