Re: [PATCH] send-email: fix uninitialized var warning for $smtp_auth

2015-09-21 Thread Junio C Hamano
Brian Norris writes: > On the latest version of git-send-email, I see this error just before > running SMTP auth (I didn't provide any --smtp-auth= parameter): > > Use of uninitialized value $smtp_auth in pattern match (m//) at >

[PATCH] send-email: fix uninitialized var warning for $smtp_auth

2015-09-18 Thread Brian Norris
On the latest version of git-send-email, I see this error just before running SMTP auth (I didn't provide any --smtp-auth= parameter): Use of uninitialized value $smtp_auth in pattern match (m//) at /usr/local/google/home/briannorris/git/git/git-send-email.perl line 1139. Signed-off-by: Brian

Re: [PATCH] send-email: fix uninitialized var warning for $smtp_auth

2015-09-18 Thread Eric Sunshine
On Fri, Sep 18, 2015 at 03:12:50PM -0700, Brian Norris wrote: > On the latest version of git-send-email, I see this error just before > running SMTP auth (I didn't provide any --smtp-auth= parameter): > > Use of uninitialized value $smtp_auth in pattern match (m//) at >

Re: [PATCH] send-email: fix uninitialized var warning for $smtp_auth

2015-09-18 Thread Brian Norris
On Fri, Sep 18, 2015 at 06:25:24PM -0400, Eric Sunshine wrote: > On Fri, Sep 18, 2015 at 03:12:50PM -0700, Brian Norris wrote: > > --- a/git-send-email.perl > > +++ b/git-send-email.perl > > @@ -1136,7 +1136,7 @@ sub smtp_auth_maybe { > > > > # Check mechanism naming as defined in: > > #

Re: [PATCH] send-email: fix uninitialized var warning for $smtp_auth

2015-09-18 Thread Brian Norris
On Fri, Sep 18, 2015 at 06:47:20PM -0400, Eric Sunshine wrote: > Makes sense (again). Thanks for the explanation. No problem. Thanks for the review. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] send-email: fix uninitialized var warning for $smtp_auth

2015-09-18 Thread Eric Sunshine
On Fri, Sep 18, 2015 at 6:42 PM, Brian Norris wrote: > On Fri, Sep 18, 2015 at 06:25:24PM -0400, Eric Sunshine wrote: >> Thanks, makes sense. I wonder if moving the check to the point where >> $smtp_auth is actually used (despite the noisier diff) would be cleaner, >