Re: [PATCH] send-email: report host and port separately when calling git credential

2018-04-04 Thread Jeff King
On Mon, Apr 02, 2018 at 03:05:35PM -0700, Junio C Hamano wrote: > "git help credential" mentions protocol, host, path, username and > password (and also url which is a short-hand for setting protocol > and host), but not "port". And common sense tells me, when a system > allows setting host but

Re: [PATCH] send-email: report host and port separately when calling git credential

2018-04-02 Thread Junio C Hamano
Michal Nazarewicz writes: > When git-send-email uses git-credential to get SMTP password, it will > communicate SMTP host and port (if both are provided) as a single entry > ‘host=:’. This trips the ‘git-credential-store’ helper > which expects those values as separate keys

[PATCH] send-email: report host and port separately when calling git credential

2018-03-31 Thread Michal Nazarewicz
When git-send-email uses git-credential to get SMTP password, it will communicate SMTP host and port (if both are provided) as a single entry ‘host=:’. This trips the ‘git-credential-store’ helper which expects those values as separate keys (‘host’ and ‘port’). Send the values as separate pieces