Re: [PATCH] send-email: validate reconfirm interactive responses

2012-09-06 Thread Stephen Boyd
(Sorry sending this from web interface) On Wed, Sep 5, 2012 at 8:29 PM, Junio C Hamano gits...@pobox.com wrote: Stephen Boyd bebar...@gmail.com writes: This is now bugging me if I just hit enter and don't want to specify anything for these headers (I want the defaults or what's in the files

Re: [PATCH] send-email: validate reconfirm interactive responses

2012-09-06 Thread Junio C Hamano
Stephen Boyd bebar...@gmail.com writes: It works fine for Who should the emails appear to be from? but beyond that we have Who should the emails be sent to? and Message-ID to be used as In-Reply-To for the first email? which I typically just hit enter to. It seems that they have no default

Re: [PATCH] send-email: validate reconfirm interactive responses

2012-09-06 Thread Stephen Boyd
On Thu, Sep 6, 2012 at 1:03 PM, Junio C Hamano gits...@pobox.com wrote: If you let $to to go empty with the first hunk of your patch, where does the mail eventually go? Does anybody later in the code decide to add some recipient? If there is a reason why an empty input is a valid here, I

Re: [PATCH] send-email: validate reconfirm interactive responses

2012-09-05 Thread Stephen Boyd
On Tue, Aug 14, 2012 at 3:25 PM, Junio C Hamano gits...@pobox.com wrote: @@ -745,13 +752,15 @@ sub file_declares_8bit_cte { if (!defined $sender) { $sender = $repoauthor || $repocommitter || ''; $sender = ask(Who should the emails appear to be from? [$sender] , -

Re: [PATCH] send-email: validate reconfirm interactive responses

2012-09-05 Thread Junio C Hamano
Stephen Boyd bebar...@gmail.com writes: On Tue, Aug 14, 2012 at 3:25 PM, Junio C Hamano gits...@pobox.com wrote: @@ -745,13 +752,15 @@ sub file_declares_8bit_cte { if (!defined $sender) { $sender = $repoauthor || $repocommitter || ''; $sender = ask(Who should the emails

Re: [PATCH] send-email: validate reconfirm interactive responses

2012-08-14 Thread Junio C Hamano
Martin von Zweigbergk martin.von.zweigbe...@gmail.com writes: On Tue, Aug 14, 2012 at 3:25 PM, Junio C Hamano gits...@pobox.com wrote: People answer 'y' to Who should the emails appear to be from? and 'n' to Message-ID to be used as In-Reply-To for the first email? for some unknown reason.