Re: [PATCH] send-pack: don't send a thin pack when the server doesn't support it

2013-10-19 Thread Carlos Martín Nieto
On Tue, 2013-10-08 at 15:22 -0700, Jonathan Nieder wrote: > Duy Nguyen wrote: > > > Or maybe it's not that late. How about you go with your patch and add > > thin-pack capability to receive-pack too? > > > > When new "git push" is used against old server, thin pack is disabled. > > But that's not

Re: [PATCH] send-pack: don't send a thin pack when the server doesn't support it

2013-10-08 Thread Jonathan Nieder
Duy Nguyen wrote: > Or maybe it's not that late. How about you go with your patch and add > thin-pack capability to receive-pack too? > > When new "git push" is used against old server, thin pack is disabled. > But that's not a big deal (I hope). Could we have separate patches to introduce the se

Re: [PATCH] send-pack: don't send a thin pack when the server doesn't support it

2013-10-08 Thread Duy Nguyen
On Tue, Oct 8, 2013 at 4:44 PM, Duy Nguyen wrote: > On Tue, Oct 8, 2013 at 3:44 PM, Carlos Martín Nieto wrote: >> diff --git a/send-pack.c b/send-pack.c >> index 7d172ef..7b88ac8 100644 >> --- a/send-pack.c >> +++ b/send-pack.c >> @@ -205,6 +205,8 @@ int send_pack(struct send_pack_args *args, >>

Re: [PATCH] send-pack: don't send a thin pack when the server doesn't support it

2013-10-08 Thread Carlos Martin Nieto
Duy Nguyen writes: On Tue, 2013-10-08 at 16:44 +0700, Duy Nguyen wrote: >On Tue, Oct 8, 2013 at 3:44 PM, Carlos Martín Nieto wrote: > > diff --git a/send-pack.c b/send-pack.c > > index 7d172ef..7b88ac8 100644 > > --- a/send-pack.c > > +++ b/send-pack.c > > @@ -205,6 +205,8 @@ int send_pack(struc

Re: [PATCH] send-pack: don't send a thin pack when the server doesn't support it

2013-10-08 Thread Duy Nguyen
On Tue, Oct 8, 2013 at 3:44 PM, Carlos Martín Nieto wrote: > diff --git a/send-pack.c b/send-pack.c > index 7d172ef..7b88ac8 100644 > --- a/send-pack.c > +++ b/send-pack.c > @@ -205,6 +205,8 @@ int send_pack(struct send_pack_args *args, > quiet_supported = 1; > if (server_s

[PATCH] send-pack: don't send a thin pack when the server doesn't support it

2013-10-08 Thread Carlos Martín Nieto
Not every server out there supports fixing thin packs, so let's send them a full pack. Signed-off-by: Carlos Martín Nieto --- It's not always possible to support thin packs (sometimes there isn't even an object database to grab bases out of). And in any case git shouldn't create thin packs if th