Re: [PATCH] sequencer: fix --allow-empty-message behavior, make it smarter

2018-09-13 Thread Junio C Hamano
Elijah Newren writes: > This patch cleanly applies to both 2.19.0 and pu. There are some related > code cleanups that I'd like to make, but doing that cleanup conflicts with > the various rewrite-rebase-in-C topics sitting in pu; since those are > fairly lengthy, I really don't want to cause

[PATCH] sequencer: fix --allow-empty-message behavior, make it smarter

2018-09-12 Thread Elijah Newren
In commit b00bf1c9a8dd ("git-rebase: make --allow-empty-message the default", 2018-06-27), several arguments were given for transplanting empty commits without halting and asking the user for confirmation on each commit. These arguments were incomplete because the logic clearly assumed the only