Re: [PATCH] sequencer.c: terminate the last line of author-scriptproperly

2018-07-18 Thread Junio C Hamano
Phillip Wood writes: >> The only consumer of a faulty author script written by the sequencer >> is read_env_script() in sequencer.c which doesn't worry about >> checking that quotes are paired. > > That's not quite true anymore, recently another consumer > read_author_ident() was added which

Re: [PATCH] sequencer.c: terminate the last line of author-scriptproperly

2018-07-18 Thread Phillip Wood
On 18/07/18 14:50, Phillip Wood wrote: Hi Akinori On 12/07/18 12:18, Akinori MUSHA wrote: It looks like write_author_script() intends to write out a file in Bourne shell syntax, but it doesn't put a closing single quote on the last line. This patch makes .git/rebase-merge/author-script

Re: [PATCH] sequencer.c: terminate the last line of author-scriptproperly

2018-07-18 Thread Phillip Wood
On 18/07/18 10:45, Phillip Wood wrote: Hi Junio On 12/07/18 18:22, Junio C Hamano wrote: "Akinori MUSHA" writes: It looks like write_author_script() intends to write out a file in Bourne shell syntax, but it doesn't put a closing single quote on the last line. s/closing single quote/&