On 19/02/13 00:07, Junio C Hamano wrote:
I think you are misreading a suggestion that is somewhat misguided
(yes [ condition another ] does not make sense, but that is
not applicable to test conditon test another); ignore it.
It is fine to write test condition test another and that
Simon Oosthoek s.oosth...@xs4all.nl writes:
I suppose it would be fine if a patch was sent to update the entire
git-prompt.sh code to be more in line with the Git shell script style...
Please don't. We do not want a style conversion for the sole
purpose of conversion, especially when a
Minor clean up of if-then nesting in checks for environment variables
and config options. No functional changes.
---
contrib/completion/git-prompt.sh | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/contrib/completion/git-prompt.sh
Hi Martin,
Martin Erik Werner wrote:
Minor clean up of if-then nesting in checks for environment variables
and config options. No functional changes.
Yeah, the nesting was getting a little deep. Thanks for the cleanup.
May we have your sign-off?
Once this is signed off,
Reviewed-by:
On Mon, 2013-02-18 at 21:31 +0100, Simon vanaf Telefoon wrote:
Hi all, sorry for top posting :-( blame the phone and k9
I have a small issue with the use of test instead of [
If that only applies to this section of the entire file.
Coding style has some value.
Combining nested ifs with
Martin Erik Werner martinerikwer...@gmail.com writes:
On Mon, 2013-02-18 at 21:31 +0100, Simon vanaf Telefoon wrote:
Hi all, sorry for top posting :-( blame the phone and k9
I have a small issue with the use of test instead of [
If that only applies to this section of the entire file.
6 matches
Mail list logo
