Re: [PATCH] stop putting argv[0] dirname at front of PATH

2015-04-22 Thread Eric Sunshine
On Wed, Apr 22, 2015 at 2:14 PM, Jeff King p...@peff.net wrote: Subject: stop putting argv[0] dirname at front of PATH When the git wrapper is invoked, we prepend the baked-in exec-path to our PATH, so that any sub-processes we exec will all find the git-foo commands that match the wrapper

[PATCH] stop putting argv[0] dirname at front of PATH

2015-04-22 Thread Jeff King
On Wed, Apr 22, 2015 at 10:46:57AM -0700, Junio C Hamano wrote: If we can get away with just dropping this element from the PATH, I'd much rather do that than try to implement a complicated path-precedence scheme. I am OK with dropping it at a major version boundary with deprecation

Re: [PATCH] stop putting argv[0] dirname at front of PATH

2015-04-22 Thread Jeff King
On Wed, Apr 22, 2015 at 02:23:27PM -0400, Eric Sunshine wrote: On Wed, Apr 22, 2015 at 2:14 PM, Jeff King p...@peff.net wrote: Subject: stop putting argv[0] dirname at front of PATH When the git wrapper is invoked, we prepend the baked-in exec-path to our PATH, so that any sub-processes

Re: [PATCH] stop putting argv[0] dirname at front of PATH

2015-04-22 Thread Jonathan Nieder
Hi, Jeff King wrote: This was added long ago by by 231af83 (Teach the git command to handle some commands internally, 2006-02-26), with the intent that things would just work if you did something like: cd /opt tar xzf premade-git-package.tar.gz

Re: [PATCH] stop putting argv[0] dirname at front of PATH

2015-04-22 Thread Jeff King
On Wed, Apr 22, 2015 at 12:23:17PM -0700, Jonathan Nieder wrote: And not just for finding binaries; we want to find $(sharedir), etc, the same way. The RUNTIME_PREFIX build knob does this the right way Makes sense. For the