Re: [PATCH] string_list API: document what sorted means.

2012-09-19 Thread Michael Haggerty
On 09/18/2012 07:21 PM, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: If another sort order is needed, then we will either have to audit existing string_list users to make sure that they don't rely on strcmp() ordering, or we will have to implement strcmp() ordering

Re: [PATCH] string_list API: document what sorted means.

2012-09-18 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: If another sort order is needed, then we will either have to audit existing string_list users to make sure that they don't rely on strcmp() ordering, or we will have to implement strcmp() ordering *plus* the new ordering. What I was envisioning

Re: [PATCH] string_list API: document what sorted means.

2012-09-17 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: Junio pointed out that the sort order currently used by string_list could be considered to be an implementation detail internal to string_list. But the sort order is already visible to the outside world (e.g., via iteration or via