Re: [PATCH] submodule: Fetch the direct sha1 first

2016-02-22 Thread Jens Lehmann
Am 20.02.2016 um 01:11 schrieb Junio C Hamano: Stefan Beller writes: On Fri, Feb 19, 2016 at 2:29 PM, Junio C Hamano wrote: Stefan Beller writes: Doing a 'git fetch' only and not the fetch for the specific sha1 would be

Re: [PATCH] submodule: Fetch the direct sha1 first

2016-02-20 Thread Jacob Keller
On Fri, Feb 19, 2016 at 1:13 PM, Junio C Hamano wrote: >> Regarding performance, the first fetch should fail quite fast iff the fetch >> fails and then continue with the normal fetch. In case the first fetch works >> fine getting the exact sha1, the fetch should be faster than

Re: [PATCH] submodule: Fetch the direct sha1 first

2016-02-19 Thread Junio C Hamano
Stefan Beller writes: > On Fri, Feb 19, 2016 at 2:29 PM, Junio C Hamano wrote: >> Stefan Beller writes: >> >>> Doing a 'git fetch' only and not the fetch for the specific sha1 would be >>> incorrect? >> >> I thought that was what you

Re: [PATCH] submodule: Fetch the direct sha1 first

2016-02-19 Thread Stefan Beller
On Fri, Feb 19, 2016 at 2:29 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Doing a 'git fetch' only and not the fetch for the specific sha1 would be >> incorrect? > > I thought that was what you are attempting to address. Yep. In an ideal world I

Re: [PATCH] submodule: Fetch the direct sha1 first

2016-02-19 Thread Junio C Hamano
Stefan Beller writes: > Doing a 'git fetch' only and not the fetch for the specific sha1 would be > incorrect? I thought that was what you are attempting to address. > ('git fetch' with no args finishes successfully, so no fallback is > triggered. But we are not sure if we

Re: [PATCH] submodule: Fetch the direct sha1 first

2016-02-19 Thread Stefan Beller
On Fri, Feb 19, 2016 at 1:13 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> When reviewing a change in Gerrit, which also updates a submodule, >> a common review practice is to download and cherry-pick the patch locally >> to test it. However when

Re: [PATCH] submodule: Fetch the direct sha1 first

2016-02-19 Thread Junio C Hamano
Stefan Beller writes: > When reviewing a change in Gerrit, which also updates a submodule, > a common review practice is to download and cherry-pick the patch locally > to test it. However when testing it locally, the 'git submodule update' > may fail fetching the correct

[PATCH] submodule: Fetch the direct sha1 first

2016-02-19 Thread Stefan Beller
When reviewing a change in Gerrit, which also updates a submodule, a common review practice is to download and cherry-pick the patch locally to test it. However when testing it locally, the 'git submodule update' may fail fetching the correct submodule sha1 as the corresponding commit in the