Re: [PATCH] submodule: add more exhaustive up-path testing

2018-08-14 Thread Stefan Beller
On Tue, Aug 14, 2018 at 2:16 PM Ævar Arnfjörð Bjarmason wrote: > > > On Tue, Aug 14 2018, Stefan Beller wrote: > > > On Tue, Aug 14, 2018 at 2:05 PM Ævar Arnfjörð Bjarmason > > wrote: > > > >> > So ideally we'd also error out as soon as the host name is touched? > >> > >> Do we have some utility

Re: [PATCH] submodule: add more exhaustive up-path testing

2018-08-14 Thread Ævar Arnfjörð Bjarmason
On Tue, Aug 14 2018, Stefan Beller wrote: > On Tue, Aug 14, 2018 at 2:05 PM Ævar Arnfjörð Bjarmason > wrote: > >> > So ideally we'd also error out as soon as the host name is touched? >> >> Do we have some utility function that'll take whatever we have in >> remote..url and spew out the

Re: [PATCH] submodule: add more exhaustive up-path testing

2018-08-14 Thread Stefan Beller
On Tue, Aug 14, 2018 at 2:05 PM Ævar Arnfjörð Bjarmason wrote: > > So ideally we'd also error out as soon as the host name is touched? > > Do we have some utility function that'll take whatever we have in > remote..url and spew out the username / host / path? We must, > since the clone protocol

Re: [PATCH] submodule: add more exhaustive up-path testing

2018-08-14 Thread Ævar Arnfjörð Bjarmason
On Tue, Aug 14 2018, Stefan Beller wrote: > On Tue, Aug 14, 2018 at 11:59 AM Ævar Arnfjörð Bjarmason > wrote: >> >> The tests added in 63e95beb08 ("submodule: port resolve_relative_url >> from shell to C", 2016-04-15) didn't do a good job of testing various >> up-path invocations where the

Re: [PATCH] submodule: add more exhaustive up-path testing

2018-08-14 Thread Junio C Hamano
Stefan Beller writes: > Thanks for this patch! > Stefan Thanks, I'd take it as your Acked-by: (please holler if it isn't before the patch hits 'next').

Re: [PATCH] submodule: add more exhaustive up-path testing

2018-08-14 Thread Stefan Beller
On Tue, Aug 14, 2018 at 11:59 AM Ævar Arnfjörð Bjarmason wrote: > > The tests added in 63e95beb08 ("submodule: port resolve_relative_url > from shell to C", 2016-04-15) didn't do a good job of testing various > up-path invocations where the up-path would bring us beyond even the > URL in question

[PATCH] submodule: add more exhaustive up-path testing

2018-08-14 Thread Ævar Arnfjörð Bjarmason
The tests added in 63e95beb08 ("submodule: port resolve_relative_url from shell to C", 2016-04-15) didn't do a good job of testing various up-path invocations where the up-path would bring us beyond even the URL in question without emitting an error. These results look nonsensical, but it's worth