Re: [PATCH] submodule: fix NULL correctness in renamed broken submodules

2018-06-17 Thread Kaartic Sivaraam
On Thursday 14 June 2018 11:01 PM, Stefan Beller wrote: > While at it, make sure we only attempt to load the submodule if a git > directory of the submodule is found as default_name_or_path will return > NULL in case the git directory cannot be found. I found this a little hard to read. Maybe it

Re: [PATCH] submodule: fix NULL correctness in renamed broken submodules

2018-06-14 Thread Heiko Voigt
Hi, On Thu, Jun 14, 2018 at 10:31:07AM -0700, Stefan Beller wrote: > When fetching with recursing into submodules, the fetch logic inspects > the superproject which submodules actually need to be fetched. This is > tricky for submodules that were renamed in the fetched range of commits. > This

[PATCH] submodule: fix NULL correctness in renamed broken submodules

2018-06-14 Thread Stefan Beller
When fetching with recursing into submodules, the fetch logic inspects the superproject which submodules actually need to be fetched. This is tricky for submodules that were renamed in the fetched range of commits. This was implemented in c68f8375760 (implement fetching of moved submodules,