Re: [PATCH] submodule: teach foreach command a --revision tree-ish option

2012-10-09 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Assuming that the above guess is correct (which is a huge assumption, given the lack of clarity in the description), I think the feature might make sense. The example would have been a lot easier to follow if it were something like this: $ git

Re: [PATCH] submodule: teach foreach command a --revision tree-ish option

2012-10-09 Thread Jay Soffian
On Tue, Oct 9, 2012 at 2:12 AM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: Assuming that the above guess is correct (which is a huge assumption, given the lack of clarity in the description), I think the feature might make sense. The example would have

Re: [PATCH] submodule: teach foreach command a --revision tree-ish option

2012-10-09 Thread Junio C Hamano
Jay Soffian jaysoff...@gmail.com writes: On Tue, Oct 9, 2012 at 2:12 AM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: Assuming that the above guess is correct (which is a huge assumption, given the lack of clarity in the description), I think the feature

Re: [PATCH] submodule: teach foreach command a --revision tree-ish option

2012-10-09 Thread Jens Lehmann
Am 09.10.2012 20:24, schrieb Junio C Hamano: Jay Soffian jaysoff...@gmail.com writes: On Tue, Oct 9, 2012 at 2:12 AM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: Assuming that the above guess is correct (which is a huge assumption, given the lack of

Re: [PATCH] submodule: teach foreach command a --revision tree-ish option

2012-10-09 Thread Jay Soffian
On Tue, Oct 9, 2012 at 5:21 PM, Jens Lehmann jens.lehm...@web.de wrote: Nothing I can think of right now, the above is a pretty good summary. My gut feeling is that having git submodule foreach --revision ... recurse through submodules whose work trees are out of sync is pretty fragile and

Re: [PATCH] submodule: teach foreach command a --revision tree-ish option

2012-10-09 Thread Junio C Hamano
Jens Lehmann jens.lehm...@web.de writes: Am 09.10.2012 20:24, schrieb Junio C Hamano: ... I think the right approach to implement this recurse foreach in the superproject tree that is not checkout out to the working tree feature should be: - Advertise it so that it is crystal clear that

[PATCH] submodule: teach foreach command a --revision tree-ish option

2012-10-08 Thread Jay Soffian
Teach git submodule foreach a --revision tree-ish option. This is useful in combination with $sha1 to perform git commands that take a revision argument. For example: $ git submodule foreach --revision v1.0 'git tag v1.0 $sha1' Previously, this would have required multiple steps: $ git

Re: [PATCH] submodule: teach foreach command a --revision tree-ish option

2012-10-08 Thread Junio C Hamano
Jay Soffian jaysoff...@gmail.com writes: Teach git submodule foreach a --revision tree-ish option. This is useful in combination with $sha1 to perform git commands that take a revision argument. The above says: - --revision T is added. OK. There is no information whatsoever what it