Re: [PATCH] submodule helper: convert relative URL to absolute URL if needed

2018-10-16 Thread Jonathan Nieder
Stefan Beller wrote: > Reported-by: Jaewoong Jung > Signed-off-by: Stefan Beller > --- > builtin/submodule--helper.c | 51 - > t/t7400-submodule-basic.sh | 24 + > 2 files changed, 58 insertions(+), 17 deletions(-) Reviewed-by: Jonathan

[PATCH] submodule helper: convert relative URL to absolute URL if needed

2018-10-16 Thread Stefan Beller
The submodule helper update_clone called by "git submodule update", clones submodules if needed. As submodules used to have the URL indicating if they were active, the step to resolve relative URLs was done in the "submodule init" step. Nowadays submodules can be configured active without calling

Re: [PATCH] submodule helper: convert relative URL to absolute URL if needed

2018-10-15 Thread Junio C Hamano
Jonathan Nieder writes: >> git config submodule.active . >> git submodule update >> fatal: repository '../plugins/codemirror-editor' does not exist >> fatal: clone of '../plugins/codemirror-editor' into submodule path >> '/tmp/gerrit/plugins/codemirror-editor' failed >> Failed to clone

Re: [PATCH] submodule helper: convert relative URL to absolute URL if needed

2018-10-15 Thread Jonathan Nieder
Hi, Stefan Beller wrote: > The submodule helper update_clone called by "git submodule update", > clones submodules if needed. As submodules used to have the URL indicating > if they were active, the step to resolve relative URLs was done in the > "submodule init" step. Nowadays submodules can be

[PATCH] submodule helper: convert relative URL to absolute URL if needed

2018-10-15 Thread Stefan Beller
The submodule helper update_clone called by "git submodule update", clones submodules if needed. As submodules used to have the URL indicating if they were active, the step to resolve relative URLs was done in the "submodule init" step. Nowadays submodules can be configured active without calling

Re: [PATCH] submodule helper: convert relative URL to absolute URL if needed

2018-10-12 Thread Jonathan Nieder
Hi, Stefan Beller wrote: > The submodule helper update_clone called by "git submodule update", > clones submodules if needed. As submodules used to have the URL indicating > if they were active, the step to resolve relative URLs was done in the > "submodule init" step. Nowadays submodules can be

[PATCH] submodule helper: convert relative URL to absolute URL if needed

2018-10-12 Thread Stefan Beller
The submodule helper update_clone called by "git submodule update", clones submodules if needed. As submodules used to have the URL indicating if they were active, the step to resolve relative URLs was done in the "submodule init" step. Nowadays submodules can be configured active without calling