All,
My first git patch - so shout out if I’ve got the etiquette wrong! Or of course
if I’ve missed something.
I googled around looking for solutions to my problem but just came up with a
few shell-scripts
that didn’t quite get the functionality I needed.
The first patch fixes some typos that cre
From: Nick Townsend
Subject: Re: [PATCH] submodule recursion in git-archive
Date: 2 December 2013 15:55:36 GMT-8
To: Heiko Voigt
Cc: Junio C Hamano , René Scharfe , Jens
Lehmann , git@vger.kernel.org, Jeff King
On 29 Nov 2013, at 14:38, Heiko Voigt wrote:
> On Wed, Nov 27, 2013 at 11
Am 26.11.2013 01:04, schrieb Nick Townsend:
> My first git patch - so shout out if I’ve got the etiquette wrong! Or
> of course if I’ve missed something.
Thanks for the patches! Please send only one per message (the second
one as a reply to the first one, or both as replies to a cover letter),
th
Am 26.11.2013 16:17, schrieb René Scharfe:
> Am 26.11.2013 01:04, schrieb Nick Townsend:
>> diff --git a/Documentation/git-archive.txt b/Documentation/git-archive.txt
>> index b97aaab..b4df735 100644
>> --- a/Documentation/git-archive.txt
>> +++ b/Documentation/git-archive.txt
>> @@ -11,6 +11,7 @@
René Scharfe writes:
> Thanks for the patches! Please send only one per message (the second
> one as a reply to the first one, or both as replies to a cover letter),
> though -- that makes commenting on them much easier.
>
> Side note: Documentation/SubmittingPatches doesn't mention that (yet),
Am 26.11.2013 23:18, schrieb Junio C Hamano:
> René Scharfe writes:
>
>> Thanks for the patches! Please send only one per message (the second
>> one as a reply to the first one, or both as replies to a cover letter),
>> though -- that makes commenting on them much easier.
>>
>> Side note: Docume
On 26 Nov 2013, at 16:28, René Scharfe wrote:
> Am 26.11.2013 23:18, schrieb Junio C Hamano:
>> René Scharfe writes:
>>
>>> Thanks for the patches! Please send only one per message (the second
>>> one as a reply to the first one, or both as replies to a cover letter),
>>> though -- that makes
On 26 Nov 2013, at 14:38, Heiko Voigt wrote:
> Hi,
>
> I like where this is going.
>
> On Tue, Nov 26, 2013 at 04:17:43PM +0100, René Scharfe wrote:
>> Am 26.11.2013 01:04, schrieb Nick Townsend:
>>> + strbuf_addstr(&dotgit, work_tree);
>>> + strbuf_addch(&dotgit, '/');
>>>
On 26 Nov 2013, at 14:18, Junio C Hamano wrote:
> René Scharfe writes:
>
>> Thanks for the patches! Please send only one per message (the second
>> one as a reply to the first one, or both as replies to a cover letter),
>> though -- that makes commenting on them much easier.
>>
>> Side note:
On 26 Nov 2013, at 07:17, René Scharfe wrote:
> Am 26.11.2013 01:04, schrieb Nick Townsend:
>> My first git patch - so shout out if I’ve got the etiquette wrong! Or
>> of course if I’ve missed something.
>
> Thanks for the patches! Please send only one per message (the second
> one as a reply t
René Scharfe writes:
> OK, but the repetition of "cover letter" and "e-mail messages"
> irritates me slightly for some reason. What about the following?
Looks good to me; will queue, thanks.
> -- >8 --
> Subject: [PATCH] SubmittingPatches: document how to handle multiple patches
>
> Signed-off
Nick Townsend writes:
> On 26 Nov 2013, at 14:18, Junio C Hamano wrote:
>
>> Even if the code is run inside a repository with a working tree,
>> when producing a tarball out of an ancient commit that had a
>> submodule not at its current location, --recurse-submodules option
>> should do the rig
On 27 Nov 2013, at 11:43, Junio C Hamano wrote:
> Nick Townsend writes:
>
>> On 26 Nov 2013, at 14:18, Junio C Hamano wrote:
>>
>>> Even if the code is run inside a repository with a working tree,
>>> when producing a tarball out of an ancient commit that had a
>>> submodule not at its curre
Begin forwarded message:
> From: Nick Townsend
> Subject: Re: [PATCH] submodule recursion in git-archive
> Date: 2 December 2013 16:00:50 GMT-8
> To: Junio C Hamano
> Cc: René Scharfe , Jens Lehmann ,
> git@vger.kernel.org, Jeff King
>
>
> On 27 Nov 2013, at 1
Hi,
I like where this is going.
On Tue, Nov 26, 2013 at 04:17:43PM +0100, René Scharfe wrote:
> Am 26.11.2013 01:04, schrieb Nick Townsend:
> > + strbuf_addstr(&dotgit, work_tree);
> > + strbuf_addch(&dotgit, '/');
> > + if (args->treepath) {
> > +
On Wed, Nov 27, 2013 at 11:43:44AM -0800, Junio C Hamano wrote:
> Nick Townsend writes:
> > * The .gitmodules file can be dirty (easy to flag, but should we
> > allow archive to proceed?)
>
> As we are discussing "archive", which takes a tree object from the
> top-level project that is recorded i
Hi,
On Mon, Dec 02, 2013 at 03:55:36PM -0800, Nick Townsend wrote:
>
> On 29 Nov 2013, at 14:38, Heiko Voigt wrote:
> > FYI, I already started to implement this lookup of submodule paths early
> > this year[1] but have not found the time to proceed on that yet. I am
> > planning to continue on t
17 matches
Mail list logo
