Re: [PATCH] t: add clone test for files differing only in case

On Sun, Jan 21, 2018 at 03:07:28AM -0500, Eric Sunshine wrote: > On Sun, Jan 21, 2018 at 02:46:15AM -0500, Eric Sunshine wrote: > > Yep. In pretty much any other test script, this would work (it was > > developed in a stand-alone script), but t5601 (which nukes .git as its > > first action) isn't

Re: [PATCH] t: add clone test for files differing only in case

On Sun, Jan 21, 2018 at 6:50 AM, Duy Nguyen wrote: > On Sun, Jan 21, 2018 at 3:33 AM, brian m. carlson >> +test_expect_success 'clone on case-insensitive fs' ' > > We have CASE_INSENSITIVE_FS prereq. Should we use it here? I know it > does not harm running this test on

Re: [PATCH] t: add clone test for files differing only in case

On Sun, Jan 21, 2018 at 3:33 AM, brian m. carlson wrote: > We recently introduced a regression in cloning repositories onto > case-insensitive file systems where the repository contains multiple > files differing only in case. In such a case, we would segfault.

Re: [PATCH] t: add clone test for files differing only in case

On Sun, Jan 21, 2018 at 02:46:15AM -0500, Eric Sunshine wrote: > On Sun, Jan 21, 2018 at 2:33 AM, Junio C Hamano wrote: > > "brian m. carlson" writes: > >> +test_expect_success 'clone on case-insensitive fs' ' > >> + o=$(git hash-object -w

Re: [PATCH] t: add clone test for files differing only in case

On Sun, Jan 21, 2018 at 2:33 AM, Junio C Hamano wrote: > "brian m. carlson" writes: >> +test_expect_success 'clone on case-insensitive fs' ' >> + o=$(git hash-object -w --stdin > + t=$(printf "100644 X\0${o}100644 x\0${o}" | >> +

Re: [PATCH] t: add clone test for files differing only in case

"brian m. carlson" writes: > diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh > index 0f895478f0..53b2dda9d2 100755 > --- a/t/t5601-clone.sh > +++ b/t/t5601-clone.sh > @@ -611,4 +611,17 @@ test_expect_success 'GIT_TRACE_PACKFILE produces a > usable pack' ' >

Re: [PATCH] t: add clone test for files differing only in case

On Sat, Jan 20, 2018 at 3:33 PM, brian m. carlson wrote: > We recently introduced a regression in cloning repositories onto > case-insensitive file systems where the repository contains multiple > files differing only in case. In such a case, we would segfault.

[PATCH] t: add clone test for files differing only in case

We recently introduced a regression in cloning repositories onto case-insensitive file systems where the repository contains multiple files differing only in case. In such a case, we would segfault. This segfault has already been fixed (repository: pre-initialize hash algo pointer), but it's not