Re: [PATCH] t: make many tests depend less on the refs being files

2018-05-22 Thread Christian Couder
On Mon, May 21, 2018 at 9:34 PM, Stefan Beller wrote: > On Sun, May 20, 2018 at 10:51 PM, Christian Couder > wrote: >> From: David Turner >> >> So that they work under alternate ref storage backends. > > Sometimes I have

Re: [PATCH] t: make many tests depend less on the refs being files

2018-05-22 Thread Christian Couder
On Mon, May 21, 2018 at 1:49 PM, SZEDER Gábor wrote: >> > diff --git a/t/t9903-bash-prompt.sh b/t/t9903-bash-prompt.sh >> > index 8f5c811dd7..c3b89ae783 100755 >> > --- a/t/t9903-bash-prompt.sh >> > +++ b/t/t9903-bash-prompt.sh >> > @@ -148,7 +148,7 @@ test_expect_success

Re: [PATCH] t: make many tests depend less on the refs being files

2018-05-21 Thread Stefan Beller
On Sun, May 20, 2018 at 10:51 PM, Christian Couder wrote: > From: David Turner > > So that they work under alternate ref storage backends. Sometimes I have a disconnect between the subject and the commit message, (e.g. in an email reader the

Re: [PATCH] t: make many tests depend less on the refs being files

2018-05-21 Thread Johannes Schindelin
Hi, of course I messed up and did not fix the Cc: list... now fixed ;-) On Mon, 21 May 2018, Johannes Schindelin wrote: > Hi Chris, > > On Mon, 21 May 2018, Christian Couder wrote: > > > From: David Turner > > I vaguely remember that Dave suggested using a

Re: [PATCH] t: make many tests depend less on the refs being files

2018-05-21 Thread Christian Couder
Hi Dscho, On Mon, May 21, 2018 at 11:41 AM, Johannes Schindelin wrote: > > On Mon, 21 May 2018, Christian Couder wrote: > >> From: David Turner > > I vaguely remember that Dave suggested using a different email address > these days... > >

Re: [PATCH] t: make many tests depend less on the refs being files

2018-05-21 Thread SZEDER Gábor
> > diff --git a/t/t9903-bash-prompt.sh b/t/t9903-bash-prompt.sh > > index 8f5c811dd7..c3b89ae783 100755 > > --- a/t/t9903-bash-prompt.sh > > +++ b/t/t9903-bash-prompt.sh > > @@ -148,7 +148,7 @@ test_expect_success 'prompt - inside .git directory' ' > > test_expect_success 'prompt - deep inside

Re: [PATCH] t: make many tests depend less on the refs being files

2018-05-21 Thread Johannes Schindelin
Hi Chris, On Mon, 21 May 2018, Christian Couder wrote: > From: David Turner I vaguely remember that Dave suggested using a different email address these days... *clicketyclick* ah, yes:

[PATCH] t: make many tests depend less on the refs being files

2018-05-20 Thread Christian Couder
From: David Turner So that they work under alternate ref storage backends. This will be really needed when such alternate ref storage backends are developed. But this could already help by making clear to readers that some tests do not depend on which ref backend is