Junio C Hamano <gits...@pobox.com> writes: > Stefan Beller <sbel...@google.com> writes: > >> When looking through existing tests to point out good style I came across >> t1020, which has a test commented out and the comment wasn't helping me >> either of what the test should accomplish in the future. The code of the >> test is the same as the test before except setting GIT_DIR=. explicitly, >> so it did not ring a bell for me as well. > > I think this one should be clear, especially if you did notice the > one that sets GIT_DIR=. explicitly. It is saying that "git show -s > HEAD" inside the bare repository should be intelligent enough to > realize that it is inside bare repository (hence HEAD cannot be a > file in the working tree); the user's asking for "HEAD" therefore > must mean "the tip commit", and never "(by default the tip commit) > filtered to the pathspec HEAD".
I forgot to conclude that sentence: "... and it should be able to do so without the help of an explicit GIT_DIR=." > If it does not still work, shouldn't it be marked as > test_expect_failure instead of being commented out? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
