Re: [PATCH] t1304: Set LOGNAME even if USER is unset or null

2014-10-20 Thread Junio C Hamano
"W. Trevor King" writes: > On Sun, Oct 19, 2014 at 03:49:36PM -0700, Junio C Hamano wrote: >> I'll queue this as-is, but it makes me wonder if we want to do this >> without if/then/fi, e.g. >> >> : ${LOGNAME:=${USER:-$(id -u -n)} > > I'm fine with that too. > >> Spelling everything out with

Re: [PATCH] t1304: Set LOGNAME even if USER is unset or null

2014-10-20 Thread W. Trevor King
On Sun, Oct 19, 2014 at 03:49:36PM -0700, Junio C Hamano wrote: > I'll queue this as-is, but it makes me wonder if we want to do this > without if/then/fi, e.g. > > : ${LOGNAME:=${USER:-$(id -u -n)} I'm fine with that too. > Spelling everything out with if/then/fi is obviously at the other

Re: [PATCH] t1304: Set LOGNAME even if USER is unset or null

2014-10-19 Thread Junio C Hamano
"W. Trevor King" writes: > Previous LOGNAME discussion: > > * Michael Gruber on 2011-05-06 suggesting a discussing a whoami > fallback [1] (but whoami isn't POSIX). > * René Scharfe on 2011-10-14 suggesting USER as a fallback for > LOGNAME [2]. > * Matthieu Moy on 2012-09-17 suggesting droppi

[PATCH] t1304: Set LOGNAME even if USER is unset or null

2014-10-17 Thread W. Trevor King
Avoid: # ./t1304-default-acl.sh ok 1 - checking for a working acl setup ok 2 - Setup test repo not ok 3 - Objects creation does not break ACLs with restrictive umask # # # SHA1 for empty blob # check_perms_and_acl .git/objects/e6/9de29bb2d1d6434b8b29ae775