Re: [PATCH] t3404: fix use of "VAR=VAL cmd" with a shell function

2018-07-12 Thread Eric Sunshine
On Thu, Jul 12, 2018 at 7:52 PM Jeff King wrote: > (I do agree that being able to automatically catch these with a linter > would be worth brain cycles, but I cannot immediately think a of a way > to do so). Perhaps something like this[1]? [1]:

Re: [PATCH] t3404: fix use of "VAR=VAL cmd" with a shell function

2018-07-12 Thread Jeff King
On Thu, Jul 12, 2018 at 01:31:49PM -0700, Junio C Hamano wrote: > >> ...would you want to use test_when_finished here (both for robustness, > >> but also to make it more clear to a reader what's going on)? > > > > Perhaps. > > Yes, but this one ends up to be overly ugly. > > The restoreing of

Re: [PATCH] t3404: fix use of "VAR=VAL cmd" with a shell function

2018-07-12 Thread Junio C Hamano
Junio C Hamano writes: >>> diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh >>> index 7e9f375a24..fd43443ff5 100755 >>> --- a/t/t3404-rebase-interactive.sh >>> +++ b/t/t3404-rebase-interactive.sh >>> @@ -280,8 +280,11 @@ test_expect_success 'retain authorship w/

Re: [PATCH] t3404: fix use of "VAR=VAL cmd" with a shell function

2018-07-12 Thread Junio C Hamano
Jeff King writes: > On Thu, Jul 12, 2018 at 01:07:51PM -0700, Junio C Hamano wrote: > >> Bash may take it happily but running test with dash reveals a breakage. >> >> This was not discovered for a long time as no tests after this test >> depended on GIT_AUTHOR_NAME to be reverted correctly back

Re: [PATCH] t3404: fix use of "VAR=VAL cmd" with a shell function

2018-07-12 Thread Jeff King
On Thu, Jul 12, 2018 at 01:07:51PM -0700, Junio C Hamano wrote: > Bash may take it happily but running test with dash reveals a breakage. > > This was not discovered for a long time as no tests after this test > depended on GIT_AUTHOR_NAME to be reverted correctly back to the > original value

[PATCH] t3404: fix use of "VAR=VAL cmd" with a shell function

2018-07-12 Thread Junio C Hamano
Bash may take it happily but running test with dash reveals a breakage. This was not discovered for a long time as no tests after this test depended on GIT_AUTHOR_NAME to be reverted correctly back to the original value after this step is done. Signed-off-by: Junio C Hamano --- * We could