Re: [PATCH] t5534: fix misleading grep invocation

2017-07-07 Thread Junio C Hamano
Johannes Schindelin writes: > Yes, there are grep versions that behave differently... how did you guess? > > I am in the middle of an extended investigation trying to assess how > feasible it would be to use a native Win32 port of BusyBox (started by > long-time Git

Re: [PATCH] t5534: fix misleading grep invocation

2017-07-07 Thread Johannes Schindelin
Hi Michael, On Thu, 6 Jul 2017, Michael J Gruber wrote: > Junio C Hamano venit, vidit, dixit 05.07.2017 18:26: > > Johannes Schindelin writes: > > > >> It seems to be a little-known feature of `grep` (and it certainly came > >> as a surprise to this here developer

Re: [PATCH] t5534: fix misleading grep invocation

2017-07-06 Thread Junio C Hamano
Michael J Gruber writes: > Junio C Hamano venit, vidit, dixit 05.07.2017 18:26: > >> The invocation this fixes is not just misleading but simply wrong. >> Nicely spotted. > > In addition, the patch makes sure to catch any rev-parse failures which > the original invocation shove

Re: [PATCH] t5534: fix misleading grep invocation

2017-07-06 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 05.07.2017 18:26: > Johannes Schindelin writes: > >> It seems to be a little-known feature of `grep` (and it certainly came >> as a surprise to this here developer who believed to know the Unix tools >> pretty well) that multiple

Re: [PATCH] t5534: fix misleading grep invocation

2017-07-05 Thread Junio C Hamano
Johannes Schindelin writes: > It seems to be a little-known feature of `grep` (and it certainly came > as a surprise to this here developer who believed to know the Unix tools > pretty well) that multiple patterns can be passed in the same > command-line argument

[PATCH] t5534: fix misleading grep invocation

2017-07-05 Thread Johannes Schindelin
It seems to be a little-known feature of `grep` (and it certainly came as a surprise to this here developer who believed to know the Unix tools pretty well) that multiple patterns can be passed in the same command-line argument simply by separating them by newlines. Watch, and learn: $