Re: [PATCH] t6300-for-each-ref: fix "more than one quoting style" tests

2018-02-15 Thread SZEDER Gábor
On Thu, Feb 15, 2018 at 5:52 PM, Jeff King wrote: > On Thu, Feb 15, 2018 at 05:39:28PM +0100, SZEDER Gábor wrote: > >> On Tue, Feb 13, 2018 at 11:22 PM, Jeff King wrote: >> >> >> for i in "--perl --shell" "-s --python" "--python --tcl" "--tcl --perl"; >> >> do >>

Re: [PATCH] t6300-for-each-ref: fix "more than one quoting style" tests

2018-02-15 Thread Jeff King
On Thu, Feb 15, 2018 at 05:39:28PM +0100, SZEDER Gábor wrote: > On Tue, Feb 13, 2018 at 11:22 PM, Jeff King wrote: > > >> for i in "--perl --shell" "-s --python" "--python --tcl" "--tcl --perl"; > >> do > >> test_expect_success "more than one quoting style: $i" " > >> -

Re: [PATCH] t6300-for-each-ref: fix "more than one quoting style" tests

2018-02-15 Thread SZEDER Gábor
On Tue, Feb 13, 2018 at 11:22 PM, Jeff King wrote: >> for i in "--perl --shell" "-s --python" "--python --tcl" "--tcl --perl"; do >> test_expect_success "more than one quoting style: $i" " >> - git for-each-ref $i 2>&1 | (read line && >> - case

Re: [PATCH] t6300-for-each-ref: fix "more than one quoting style" tests

2018-02-13 Thread Jeff King
On Tue, Feb 13, 2018 at 01:36:01AM +0100, SZEDER Gábor wrote: > 'git for-each-ref' should error out when invoked with more than one > quoting style options. The tests checking this have two issues: > > - They run 'git for-each-ref' upstream of a pipe, hiding its exit > code, thus don't

[PATCH] t6300-for-each-ref: fix "more than one quoting style" tests

2018-02-12 Thread SZEDER Gábor
'git for-each-ref' should error out when invoked with more than one quoting style options. The tests checking this have two issues: - They run 'git for-each-ref' upstream of a pipe, hiding its exit code, thus don't actually checking that 'git for-each-ref' exits with error code. -