Re: [PATCH] test-lib-functions.sh: fix the second argument to some helper functions

2015-04-20 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: Matthieu Moy matthieu@grenoble-inp.fr writes: Elia Pinto gitter.spi...@gmail.com writes: --- a/t/test-lib-functions.sh +++ b/t/test-lib-functions.sh @@ -478,7 +478,7 @@ test_external_without_stderr () { test_path_is_file () { if ! test -f

[PATCH] test-lib-functions.sh: fix the second argument to some helper functions

2015-04-16 Thread Elia Pinto
The second argument to test_path_is_file and test_path_is_dir must be $2 and not $*, which instead would repeat the file name in the error message. Signed-off-by: Elia Pinto gitter.spi...@gmail.com --- t/test-lib-functions.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] test-lib-functions.sh: fix the second argument to some helper functions

2015-04-16 Thread Matthieu Moy
Elia Pinto gitter.spi...@gmail.com writes: --- a/t/test-lib-functions.sh +++ b/t/test-lib-functions.sh @@ -478,7 +478,7 @@ test_external_without_stderr () { test_path_is_file () { if ! test -f $1 then - echo File $1 doesn't exist. $* + echo File $1

Re: [PATCH] test-lib-functions.sh: fix the second argument to some helper functions

2015-04-16 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: Elia Pinto gitter.spi...@gmail.com writes: --- a/t/test-lib-functions.sh +++ b/t/test-lib-functions.sh @@ -478,7 +478,7 @@ test_external_without_stderr () { test_path_is_file () { if ! test -f $1 then -echo File $1