Re: [PATCH] use a hashmap to make remotes faster

2014-07-29 Thread Matthieu Moy
patrick.reyno...@github.com patrick.reyno...@github.com writes: ^ It seems you mixed your name and email address in your config file. I guess your name is Patrick Reynolds, not patrick.reyno...@github.com. Remotes are stored as an array, so looking one up or adding

Re: [PATCH] use a hashmap to make remotes faster

2014-07-29 Thread Jeff King
On Tue, Jul 29, 2014 at 09:57:45AM +0200, Matthieu Moy wrote: patrick.reyno...@github.com patrick.reyno...@github.com writes: ^ It seems you mixed your name and email address in your config file. I guess your name is Patrick Reynolds, not

[PATCH] use a hashmap to make remotes faster

2014-07-28 Thread patrick.reyno...@github.com
Remotes are stored as an array, so looking one up or adding one without duplication is an O(n) operation. Reading an entire config file full of remotes is O(n^2) in the number of remotes. For a repository with tens of thousands of remotes, the running time can hit multiple minutes. Hash tables