Re: [PATCH] utf8: NO_ICONV: silence uninitialized variable warning

2015-06-05 Thread Junio C Hamano
Jeff King writes: > So I think your patch is the best option, but it might be good to give > one more look at the callers to be sure we are not missing something. The two callers both leave the outsz uninitialized and to a human it is obvious that uninitialized outsz is never used when the funct

Re: [PATCH] utf8: NO_ICONV: silence uninitialized variable warning

2015-06-05 Thread Jeff King
On Fri, Jun 05, 2015 at 02:42:16AM -0400, Eric Sunshine wrote: > The last argument of reencode_string_len() is an 'int *' which is > assigned the length of the converted string. When NO_ICONV is defined, > however, reencode_string_len() is stubbed out by the macro: > > #define reencode_string

[PATCH] utf8: NO_ICONV: silence uninitialized variable warning

2015-06-04 Thread Eric Sunshine
The last argument of reencode_string_len() is an 'int *' which is assigned the length of the converted string. When NO_ICONV is defined, however, reencode_string_len() is stubbed out by the macro: #define reencode_string_len(a,b,c,d,e) NULL which never assigns a value to the final argument. W