Re: [PATCH] utf8.c: print warning about disabled iconv

2015-06-08 Thread Junio C Hamano
Max Kirillov m...@max630.net writes: User, in theory, can be not the same person who builds, or can be not aware that the case needs recoding. Because you can pretty much say the same for build with iconv enabled, I think that line of argument is futile. The users do not have control over

Re: [PATCH] utf8.c: print warning about disabled iconv

2015-06-08 Thread Max Kirillov
Hi. On Mon, Jun 08, 2015 at 09:16:16AM -0700, Junio C Hamano wrote: Max Kirillov m...@max630.net writes: This gives undesirable result that returned data or even data written into repository is incorrect and user is not aware about it. I do not necessarily agree with that. The user knows

Re: [PATCH] utf8.c: print warning about disabled iconv

2015-06-08 Thread Junio C Hamano
Max Kirillov m...@max630.net writes: It is an allowed compile-time option to build git without iconv support. Resulting build almost always functions correctly, and never displays that it is missing anything, but reencode_string_len() just never modifies its input. Correct. This gives

[PATCH] utf8.c: print warning about disabled iconv

2015-06-06 Thread Max Kirillov
It is an allowed compile-time option to build git without iconv support. Resulting build almost always functions correctly, and never displays that it is missing anything, but reencode_string_len() just never modifies its input. This gives undesirable result that returned data or even data written