Re: [PATCH] wildmatch: properly fold case everywhere

2013-05-30 Thread Eric Sunshine
On Thu, May 30, 2013 at 5:29 AM, Anthony Ramine wrote: > Yes indeed. Will amend. Should I add your name in Reviewed-by as well? No. I merely spotted a minor typographical error. > -- > Anthony Ramine > > Le 30 mai 2013 à 11:07, Eric Sunshine a écrit : > >> On Thu, May 30, 2013 at 4:45 AM, Anthon

Re: [PATCH] wildmatch: properly fold case everywhere

2013-05-30 Thread Anthony Ramine
Yes indeed. Will amend. Should I add your name in Reviewed-by as well? -- Anthony Ramine Le 30 mai 2013 à 11:07, Eric Sunshine a écrit : > On Thu, May 30, 2013 at 4:45 AM, Anthony Ramine wrote: >> Case folding is not done correctly when matching against the [:upper:] >> character class and upp

Re: [PATCH] wildmatch: properly fold case everywhere

2013-05-30 Thread Eric Sunshine
On Thu, May 30, 2013 at 4:45 AM, Anthony Ramine wrote: > Case folding is not done correctly when matching against the [:upper:] > character class and uppercased character ranges (e.g. A-Z). > Specifically, an uppercase letter fails to match against any of them > when case folding is requested beca

Re: [PATCH] wildmatch: properly fold case everywhere

2013-05-30 Thread Duy Nguyen
On Thu, May 30, 2013 at 3:45 PM, Anthony Ramine wrote: > Case folding is not done correctly when matching against the [:upper:] > character class and uppercased character ranges (e.g. A-Z). > Specifically, an uppercase letter fails to match against any of them > when case folding is requested beca

[PATCH] wildmatch: properly fold case everywhere

2013-05-30 Thread Anthony Ramine
Case folding is not done correctly when matching against the [:upper:] character class and uppercased character ranges (e.g. A-Z). Specifically, an uppercase letter fails to match against any of them when case folding is requested because plain characters in the pattern and the whole string and pre

Re: [PATCH] wildmatch: properly fold case everywhere

2013-05-28 Thread Anthony Ramine
You're right, I will amend my patch. How do I make git-send-email reply to that thread? -- Anthony Ramine Le 28 mai 2013 à 14:53, Duy Nguyen a écrit : > On Tue, May 28, 2013 at 7:32 PM, Anthony Ramine wrote: >> @@ -196,6 +196,11 @@ static int dowild(const uchar *p, const uchar *text, >> unsi

Re: [PATCH] wildmatch: properly fold case everywhere

2013-05-28 Thread Duy Nguyen
On Tue, May 28, 2013 at 7:32 PM, Anthony Ramine wrote: > @@ -196,6 +196,11 @@ static int dowild(const uchar *p, const uchar *text, > unsigned int flags) > } > if (t_ch <= p_ch && t_ch >= prev_ch) >

[PATCH] wildmatch: properly fold case everywhere

2013-05-28 Thread Anthony Ramine
Case folding is not done correctly when matching against the [:upper:] character class and uppercased character ranges (e.g. A-Z). Specifically, an uppercase letter fails to match against any of them when case folding is requested because plain characters in the pattern and the whole string and pre