Re: [PATCH 0/1] Fix a long-standing isatty() problem on Windows

2016-12-12 Thread Junio C Hamano
Johannes Schindelin writes: >> This is a great find, and a very impactful fix, as redirecting from >> /dev/null is how we try to force a "go interactive if talking to >> tty" program to realize that it is not talking to a tty. > > Can we fast-track this to maint? Yes, "fast-track" is a good phra

Re: [PATCH 0/1] Fix a long-standing isatty() problem on Windows

2016-12-12 Thread Johannes Schindelin
Hi Junio, On Sun, 11 Dec 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > I finally got a chance to debug the problems with the ever-timing-out > > test runs of `pu` on Windows. Turns out that pb/bisect uncovered a > > really old, really bad bug: on Windows, isatty() does not do

Re: [PATCH 0/1] Fix a long-standing isatty() problem on Windows

2016-12-11 Thread Junio C Hamano
Johannes Schindelin writes: > I finally got a chance to debug the problems with the ever-timing-out > test runs of `pu` on Windows. Turns out that pb/bisect uncovered a > really old, really bad bug: on Windows, isatty() does not do what Git > expects, at least not completely: it detects interacti

[PATCH 0/1] Fix a long-standing isatty() problem on Windows

2016-12-11 Thread Johannes Schindelin
I finally got a chance to debug the problems with the ever-timing-out test runs of `pu` on Windows. Turns out that pb/bisect uncovered a really old, really bad bug: on Windows, isatty() does not do what Git expects, at least not completely: it detects interactive terminals *and character devices*.