Re: [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase

2018-08-29 Thread Johannes Schindelin
Hi Jonathan, On Tue, 28 Aug 2018, Jonathan Nieder wrote: > Johannes Schindelin wrote: > > On Mon, 27 Aug 2018, Junio C Hamano wrote: > >> Johannes Schindelin writes: > >>> Jonathan Nieder wrote: > > Please include this information in the commit message. It's super > helpful to find t

Re: [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase

2018-08-29 Thread Johannes Schindelin
Hi Junio, On Tue, 28 Aug 2018, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> I do recall discouraging you from including irrelevant rant/whine in > >> the log message a few times in the recent past, and also I do recall > >> you never listening to me. Don't make me an excuse. > >

Re: [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase

2018-08-28 Thread Jonathan Nieder
Johannes Schindelin wrote: > On Mon, 27 Aug 2018, Junio C Hamano wrote: >> Johannes Schindelin writes: >>> Jonathan Nieder wrote: Please include this information in the commit message. It's super helpful to find this kind of information about why a patch does what it does when enc

Re: [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase

2018-08-28 Thread Junio C Hamano
Johannes Schindelin writes: >> I do recall discouraging you from including irrelevant rant/whine in >> the log message a few times in the recent past, and also I do recall >> you never listening to me. Don't make me an excuse. > > Junio, I would really appreciate less emotional, and more profess

Re: [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase

2018-08-28 Thread Johannes Schindelin
Hi Junio, On Mon, 27 Aug 2018, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> Please include this information in the commit message. It's super > >> helpful to find this kind of information about why a patch does what > >> it does when encountering a patch later "in the wild" (in g

Re: [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase

2018-08-27 Thread Junio C Hamano
Johannes Schindelin writes: >> Please include this information in the commit message. It's super >> helpful to find this kind of information about why a patch does what >> it does when encountering a patch later "in the wild" (in git log -S >> output). > > I thought I did include the relevant pa

Re: [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase

2018-08-25 Thread Johannes Schindelin
Hi Jonathan, On Wed, 22 Aug 2018, Jonathan Nieder wrote: > Johannes Schindelin wrote: > > [nice description snipped] > > This patch fixes that. > > Please include this information in the commit message. It's super > helpful to find this kind of information about why a patch does what > it does

Re: [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase

2018-08-22 Thread Jonathan Nieder
Hi, Johannes Schindelin wrote: [nice description snipped] > This patch fixes that. Please include this information in the commit message. It's super helpful to find this kind of information about why a patch does what it does when encountering a patch later "in the wild" (in git log -S output).

Re: [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase

2018-08-22 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > This patch fixes that. > > Note: while this patch targets pk/rebase-in-c-6-final, it will not work > correctly without ag/rebase-i-in-c. So my suggestion is to rewrite the > pk/rebas-in-c-6-final branch by first merging ag/rebase-i-in-c, then > ap

[PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase

2018-08-22 Thread Johannes Schindelin via GitGitGadget
The builtin rebase and the builtin interactive rebase have been developed independently, on purpose: Google Summer of Code rules specifically state that students have to work on independent projects, they cannot collaborate on the same project. The reason is probably the very fine tradition in aca